From 492211f4990d44686f60a21ee7fa1172e18a23a7 Mon Sep 17 00:00:00 2001 From: Ashcon Partovi Date: Wed, 17 Apr 2024 16:06:28 -0700 Subject: [PATCH] Tweak comment from PRs --- .github/workflows/build-darwin.yml | 2 +- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-windows.yml | 2 +- .github/workflows/comment.yml | 9 ++------- .github/workflows/run-test.yml | 12 ++++++++++-- 5 files changed, 15 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build-darwin.yml b/.github/workflows/build-darwin.yml index 5b0f1db53bdcd5..dc37d599b5d90d 100644 --- a/.github/workflows/build-darwin.yml +++ b/.github/workflows/build-darwin.yml @@ -299,4 +299,4 @@ jobs: @${{ github.actor }}, the build for bun-${{ inputs.tag }} failed. - **[View logs](${{ github.event.workflow_run.logs_url }})** + **[View logs](${{ github.event.workflow_run.html_url }})** diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 779ad9bf22c982..dcc0e97d6b8236 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -56,4 +56,4 @@ jobs: @${{ github.actor }}, the build for bun-${{ inputs.tag }} failed. - **[View logs](${{ github.event.workflow_run.logs_url }})** + **[View logs](${{ github.event.workflow_run.html_url }})** diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index c7e3dbdbbdb615..7584124b68458f 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -319,4 +319,4 @@ jobs: @${{ github.actor }}, the build for bun-${{ inputs.tag }} failed. - **[View logs](${{ github.event.workflow_run.logs_url }})** + **[View logs](${{ github.event.workflow_run.html_url }})** diff --git a/.github/workflows/comment.yml b/.github/workflows/comment.yml index cd7d9ff9c5907f..01e42b401f9e80 100644 --- a/.github/workflows/comment.yml +++ b/.github/workflows/comment.yml @@ -23,11 +23,6 @@ jobs: pattern: bun-*-tests github-token: ${{ github.token }} run-id: ${{ github.event.workflow_run.id }} - - name: Setup SSH - if: ${{ github.triggering_actor == 'Electroid' }} - uses: mxschmitt/action-tmate@v3 - with: - limit-access-to-actor: true - name: Setup Environment id: env shell: bash @@ -37,11 +32,11 @@ jobs: run: | cat bun/bun-*-tests/comment.md > comment.md if [ -s comment.md ]; then - echo -e "❌ @${{ github.actor }}, there are failing tests: \n$(cat comment.md)" > comment.md + echo -e "❌ @${{ github.actor }}, there are failing tests: \n\n$(cat comment.md)" > comment.md else echo -e "✅ @${{ github.actor }}, all tests passed!" > comment.md fi - echo -e "\n**[View logs](${{ github.event.workflow_run.logs_url }})**" >> comment.md + echo -e "\n**[View logs](${{ github.event.workflow_run.html_url }})**" >> comment.md echo -e "" >> comment.md - name: Find Comment id: comment diff --git a/.github/workflows/run-test.yml b/.github/workflows/run-test.yml index f30729b825bb0a..8ce1bec7d3a138 100644 --- a/.github/workflows/run-test.yml +++ b/.github/workflows/run-test.yml @@ -29,7 +29,7 @@ on: jobs: test: - name: Test + name: Run Tests runs-on: ${{ inputs.runs-on }} steps: - name: Checkout @@ -75,7 +75,15 @@ jobs: shell: bash run: | bun install + - name: Install Dependencies (test) + timeout-minutes: 5 + shell: bash + run: | bun install --cwd test + - name: Install Dependencies (runner) + timeout-minutes: 5 + shell: bash + run: | bun install --cwd packages/bun-internal-test - name: Run Tests id: test @@ -115,7 +123,7 @@ jobs: ${{ steps.test.outputs.failing_tests }} - **[View logs](${{ github.event.workflow_run.logs_url }})** + **[View logs](${{ github.event.workflow_run.html_url }})** - name: Fail if: ${{ failure() }} run: |