Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Code Coverage #74

Open
darkfrog26 opened this issue Jun 6, 2018 · 5 comments
Open

Better Code Coverage #74

darkfrog26 opened this issue Jun 6, 2018 · 5 comments

Comments

@darkfrog26
Copy link
Contributor

While 100% coverage isn't usually practical, we need to raise our numbers.

@darkfrog26 darkfrog26 added this to the 2.6.0 milestone Jun 6, 2018
@darkfrog26 darkfrog26 modified the milestones: 2.6.0, 2.7.0 Aug 27, 2018
@darkfrog26 darkfrog26 removed this from the 2.7.0 milestone Nov 17, 2018
@darkfrog26 darkfrog26 added this to the 3.0 milestone Oct 21, 2020
@darkfrog26 darkfrog26 modified the milestones: 3.0, 3.1 Nov 3, 2020
@darkfrog26 darkfrog26 modified the milestones: 3.1, 3.2 Nov 24, 2020
@darkfrog26 darkfrog26 modified the milestones: 3.2, 3.3 Jan 4, 2021
@qerat97
Copy link

qerat97 commented Jan 16, 2021

Is this issue resolved ? if not how can i start contributing to this Issue.

@darkfrog26
Copy link
Contributor Author

This is not resolved. You can see the current code coverage with:

sbt coverage coreJVM/test fileModuleJVM/test slf4j/test slf4j18/test coverageReport

You can help to increase the coverage by making sure the unit tests validate more of the logic in Scribe. Please let me know if you need any assistance. This would be a great help. :)

@qerat97
Copy link

qerat97 commented Jan 25, 2021

sbt coverage coreJVM/test fileModuleJVM/test slf4j/test slf4j18/test coverageReport

First of all sorry for the late reply. I have been a little sick last week. Will try to contribute as much as possible this week.

Thanks for the command. I ran the command and ran into error shown in the screenshot. Can please let me know if I am missing any package installation.

error1

@darkfrog26
Copy link
Contributor Author

try this instead:

sbt coverage coreJVM/test coreJVM/coverageReport

scoverage changed the way the plugin works. That will give you the report for the core project.

@qerat97
Copy link

qerat97 commented Jan 25, 2021

try this instead:

sbt coverage coreJVM/test coreJVM/coverageReport

scoverage changed the way the plugin works. That will give you the report for the core project.

Was able to generate the coverage report for coreJVM folder with this command. Thanks 👍

@darkfrog26 darkfrog26 removed this from the 3.3 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants