Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_date, max_date to lineage-by-sub-admin-most-recent #83

Open
flaneuse opened this issue Mar 1, 2023 · 0 comments
Open

Add min_date, max_date to lineage-by-sub-admin-most-recent #83

flaneuse opened this issue Mar 1, 2023 · 0 comments
Assignees
Labels

Comments

@flaneuse
Copy link
Contributor

flaneuse commented Mar 1, 2023

Currently, the window for lineage-by-sub-admin-most-recent is specified through an ndays parameter, which calculates a window based on the number days before today.

To be more general, we want to filter dates based on either min_date and/or max_date:

  • Add a min_date param to filter dates >= min_date
  • Add a max_date param to filter dates <= max_date
  • To maintain backwards capability, retain the ndays parameter (though you might want to refactor to route it through the min_date/max_date filters instead by setting max_date={today} and min_date={today - ndays}

Should be similar to #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants