From 0be4b48485a95bfcb1ffa4f3f45a929cb26df6e2 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Mon, 27 Nov 2023 15:34:20 -0500
Subject: [PATCH] tests: Add a dedicated finalization test

This one covers `admin lock-finalization --unlock`.
---
 tests/kolainst/destructive/finalization.sh | 63 ++++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100755 tests/kolainst/destructive/finalization.sh

diff --git a/tests/kolainst/destructive/finalization.sh b/tests/kolainst/destructive/finalization.sh
new file mode 100755
index 0000000000..544cb14e2b
--- /dev/null
+++ b/tests/kolainst/destructive/finalization.sh
@@ -0,0 +1,63 @@
+#!/bin/bash
+set -xeuo pipefail
+
+. ${KOLA_EXT_DATA}/libinsttest.sh
+
+require_writable_sysroot
+prepare_tmpdir
+
+case "${AUTOPKGTEST_REBOOT_MARK:-}" in
+  "")
+  # Need to disable gpg verification for test builds
+  sed -i -e 's,gpg-verify=true,gpg-verify=false,' /etc/ostree/remotes.d/*.conf
+  # xref https://github.com/coreos/coreos-assembler/pull/2814
+  systemctl mask --now zincati
+
+  # Test the deploy --stage functionality; first, we stage a deployment
+  # reboot, and validate that it worked.
+  # Write staged-deploy commit
+  cd /ostree/repo/tmp
+  ostree checkout -H ${host_commit} t
+
+  # Create a synthetic commit for upgrade
+  ostree commit --no-bindings --parent="${host_commit}" -b staged-deploy -I --consume t
+  newcommit=$(ostree rev-parse staged-deploy)
+  ostree admin deploy --lock-finalization staged-deploy
+  systemctl show -p ActiveState ostree-finalize-staged.service | grep active
+  ostree admin status > status.txt
+  assert_file_has_content status.txt 'finalization locked'
+  # Because finalization was locked, we shouldn't deploy on shutdown
+  /tmp/autopkgtest-reboot "2"
+  ;;
+  "2") 
+  # Verify we didn't finalize
+  newcommit=$(ostree rev-parse staged-deploy)
+  booted=$(rpm-ostree status --json | jq -r .deployments[0].checksum)
+  assert_not_streq "${newcommit}" "${booted}"
+  prev_bootid=$(journalctl --list-boots -o json |jq -r '.[] | select(.index == -1) | .boot_id')
+  journalctl -b $prev_bootid -u ostree-finalize-staged.service > svc.txt
+  assert_file_has_content svc.txt 'Not finalizing'
+  ostree admin status > status.txt
+  assert_not_file_has_content status.txt 'finalization locked'
+
+  # Now re-deploy
+  ostree admin deploy --lock-finalization staged-deploy
+  ostree admin status > status.txt
+  assert_file_has_content status.txt 'finalization locked'
+  # And unlock
+  ostree admin lock-finalization --unlock
+  ostree admin status > status.txt
+  assert_not_file_has_content status.txt 'finalization locked'
+
+  /tmp/autopkgtest-reboot "3"
+  ;;
+  "3") 
+  newcommit=$(ostree rev-parse staged-deploy)
+  booted=$(rpm-ostree status --json | jq -r .deployments[0].checksum)
+  assert_streq "${newcommit}" "${booted}"
+  prev_bootid=$(journalctl --list-boots -o json |jq -r '.[] | select(.index == -1) | .boot_id')
+  journalctl -b $prev_bootid -u ostree-finalize-staged.service > svc.txt
+  assert_file_has_content svc.txt 'Bootloader updated'
+  ;;
+  *) fatal "Unexpected AUTOPKGTEST_REBOOT_MARK=${AUTOPKGTEST_REBOOT_MARK}" ;;
+esac