Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test credential access functionality and package structure refactor #856

Merged

Conversation

elainechien
Copy link
Contributor

This PR adds accessing credential functionality to the sample python package and does some refactoring to allow for better customization when using the sample package for testing.

Copy link
Contributor

@maxfisher-g maxfisher-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Two minor things:

  1. potential simplification around file reading/writing
  2. nit: if(print_logs): ought to be if print_logs: in around 5 places

sample_packages/sample_python_package/src/example.py Outdated Show resolved Hide resolved
sample_packages/sample_python_package/src/example.py Outdated Show resolved Hide resolved
sample_packages/sample_python_package/src/example.py Outdated Show resolved Hide resolved
…into add_test_credential_access_functionality

Signed-off-by: Elaine Chien <[email protected]>
@maxfisher-g maxfisher-g merged commit b1e50b9 into ossf:main Sep 22, 2023
8 checks passed
@elainechien
Copy link
Contributor Author

#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants