Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(advisors): Use potentially customized PURLs in advisor queries #8387

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

sschuberth
Copy link
Member

Do not regenerate the PURL from the package ID, but use the PURL that is already stored as part of the package as that might be a custom PURL, e.g. coming from a curation.

For VulnerableCode, this fixes a regression introduced the the refactoring in 70916bf.

Fixes #8385.

@sschuberth sschuberth requested a review from a team as a code owner March 8, 2024 14:31
@sschuberth sschuberth force-pushed the advisor-custom-purls branch from feecb2f to 9044227 Compare March 8, 2024 14:33
@sschuberth sschuberth enabled auto-merge (rebase) March 8, 2024 14:54
Do not regenerate the PURL from the package ID, but use the PURL that is
already stored as part of the package as that might be a custom PURL,
e.g. coming from a curation.

For VulnerableCode, this fixes a regression introduced by the
refactoring in 70916bf.

Fixes #8385.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth force-pushed the advisor-custom-purls branch from 9044227 to 9b58afe Compare March 9, 2024 12:11
@sschuberth sschuberth requested a review from mnonnenmacher March 9, 2024 12:12
@sschuberth sschuberth merged commit 0e3cb55 into main Mar 9, 2024
21 checks passed
@sschuberth sschuberth deleted the advisor-custom-purls branch March 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(VulnerableCode): In SPDX-based projects, no vulnerabilities are found
2 participants