From a5530e13cc6b40f36346f3bcc7c888ab9abe8451 Mon Sep 17 00:00:00 2001 From: Frank Viernau Date: Wed, 21 Feb 2024 15:17:05 +0100 Subject: [PATCH] fix(go): Disable the GOPATH mode to fix the fun tests Recently, the fun tests for `GoDep` started failing which was roughly at the same time as the major version upgrade to 1.22.0 in ORT's docker image. As the GOPATH mode will eventually be removed ^[1], just disable it now to fix the tests. In particular, do so even though the root cause of the failing tests is unkown, as `GoDep` is rather outdated and thus cannot satisfy putting in further efforts. [1]: https://github.com/golang/go/issues/41330#issuecomment-690807092 Signed-off-by: Frank Viernau --- plugins/package-managers/go/src/main/kotlin/GoDep.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/package-managers/go/src/main/kotlin/GoDep.kt b/plugins/package-managers/go/src/main/kotlin/GoDep.kt index 002417f0de5ae..4466cfe7c0e60 100644 --- a/plugins/package-managers/go/src/main/kotlin/GoDep.kt +++ b/plugins/package-managers/go/src/main/kotlin/GoDep.kt @@ -266,7 +266,7 @@ private fun resolveProjectRoot(definitionFile: File) = private fun resolveVcsInfo(importPath: String, revision: String, gopath: File): VcsInfo { val pc = ProcessCapture( "go", "get", "-d", importPath, - environment = mapOf("GOPATH" to gopath.path, "GO111MODULE" to "off") + environment = mapOf("GOPATH" to gopath.path) ) // HACK Some failure modes from "go get" can be ignored: