From 6f0c6aaadfc28392b37968f713db9a5cb5abb67d Mon Sep 17 00:00:00 2001 From: Sebastian Schuberth Date: Tue, 10 Dec 2024 17:51:51 +0100 Subject: [PATCH] ci(github): Change to Linkspector for checking Markdown link The action for markdown-link-check is not maintained anymore, and the underlying NPM package as several issues. So give the action [1] for Linkspector [2] a try instead. Note that due to [3] the action needs to run on `ubuntu-22.04`. [1]: https://github.com/UmbrellaDocs/action-linkspector [2]: https://github.com/UmbrellaDocs/linkspector [3]: https://github.com/UmbrellaDocs/action-linkspector/issues/32 Signed-off-by: Sebastian Schuberth --- .github/workflows/static-analysis.yml | 9 +++------ mlc_config.json | 25 ------------------------- 2 files changed, 3 insertions(+), 31 deletions(-) delete mode 100644 mlc_config.json diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml index 749a63f62fa21..336876ec55700 100644 --- a/.github/workflows/static-analysis.yml +++ b/.github/workflows/static-analysis.yml @@ -75,17 +75,14 @@ jobs: with: sarif_file: build/reports/detekt/merged.sarif markdown-links: - runs-on: ubuntu-24.04 + runs-on: ubuntu-22.04 steps: - name: Checkout Repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 - name: Check Links - uses: gaurav-nelson/github-action-markdown-link-check@5c5dfc0ac2e225883c0e5f03a85311ec2830d368 # v1 + uses: umbrelladocs/action-linkspector@fc382e19892aca958e189954912fe379a8df270c # v1 with: - base-branch: main - check-modified-files-only: yes - max-depth: 2 - use-quiet-mode: yes + fail_on_error: true markdownlint: runs-on: ubuntu-24.04 steps: diff --git a/mlc_config.json b/mlc_config.json deleted file mode 100644 index 7b31c383a8e99..0000000000000 --- a/mlc_config.json +++ /dev/null @@ -1,25 +0,0 @@ -{ - "ignorePatterns": [ - { - "pattern": "^#.*$" - }, - { - "pattern": "^https://bazel.build/$" - }, - { - "pattern": "^https?://localhost.*$" - }, - { - "pattern": "^https://fossid.com/$" - }, - { - "pattern": "^https://fpchat-invite.herokuapp.com/$" - }, - { - "pattern": "^https://source.android.com/setup/develop/repo$" - }, - { - "pattern": "^../../tutorial/intro(#.+)?$" - } - ] -}