Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Vimeo with "Hide from Vimeo" setting but embeds allowed on specific domains #512

Open
qrazi opened this issue Jan 6, 2023 · 4 comments

Comments

@qrazi
Copy link

qrazi commented Jan 6, 2023

A client of mine uses some third party software to regularly upload video with the settings "Hide from Vimeo" and "Embed on specific domains".

This effectively means that https://vimeo.com/12345678 cannot be added, even though the oEmbed endpoint does return an oEmbed json (https://vimeo.com/api/oembed.json?url=https://vimeo.com/12345678).

As far as I can tell embed first makes a request to the original URL (https://vimeo.com/12345678) to see if it exists, and only after retrieves oEmbed info, from https://vimeo.com/api/oembed.json?url=https://vimeo.com/12345678.

Why does that first check happen? Would it not be enough to see if you get oEmbed data back from the endpoint?

I am sure I am missing something, but I would like to understand why, so I can see if there is any workaround possible.

@andrewhawkes
Copy link

Having this same issue. The URLs work fine on Vimeo's API and returns the embed code,

@oscarotero
Copy link
Owner

I don't see this problem. I just checked this private video url (taken from wrav/oembed#136)

https://oscarotero.com/embed/demo/index.php?url=https%3A%2F%2Fvimeo.com%2F800923361

It returns the embed code from the oembed api.

@andrewhawkes
Copy link

Okay thanks - I'll take a further look!

@kelenakamura
Copy link

@andrewhawkes did this get resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants