Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhel8/9: make edge images properly sysroot.readonly=true #3053

Closed
wants to merge 3 commits into from
Closed

rhel8/9: make edge images properly sysroot.readonly=true #3053

wants to merge 3 commits into from

Conversation

runcom
Copy link
Member

@runcom runcom commented Oct 7, 2022 •
edited
Loading

There's still a path ahead to be found to upgrade existing deployments (e.g. https://pagure.io/workstation-ostree-config/blob/main/f/postprocess.sh) but this patch adds sysroot reaonly functionality for new edge images - note in f37+ anaconda already ships with code to enable all this rhinstaller/anaconda@0e00c90 (and soon RHEL afaict)

@runcom runcom marked this pull request as draft October 7, 2022 14:10
@runcom
Copy link
Member Author

runcom commented Oct 7, 2022

cc @achilleas-k

@achilleas-k achilleas-k added the WIP+test Work in progress but run Gitlab CI. label Oct 7, 2022
schutzbot
schutzbot reviewed Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD adb6683 with the main merge-base 10a981c). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3142903196/artifacts/browse

@runcom
Copy link
Member Author

runcom commented Oct 12, 2022

xref for the migration ostreedev/ostree#2734

@runcom runcom mentioned this pull request Nov 11, 2022
Merged
8 tasks
@achilleas-k
Copy link
Member

I included this in #3120 since RHEL and Fedora share a lot of the pipeline generation code now. I'll keep it open until that's merged but maybe have a look and let me know if there's anything I missed.

I'd link to specific commits but the IDs are definitely going to change while I rebase.
Check the test changes in the commit with subject test/ansible: sysroot should be mounted as ro in RHEL 9.x and CS9.

@runcom
Copy link
Member Author

runcom commented Nov 28, 2022

Check the test changes in the commit with subject test/ansible: sysroot should be mounted as ro in RHEL 9.x and CS9.

cc @henrywang (I'm also pulling this in #3130 for testing)

@runcom runcom marked this pull request as ready for review November 28, 2022 11:47
@runcom
Copy link
Member Author

runcom commented Nov 29, 2022

I included this in #3120 since RHEL and Fedora share a lot of the pipeline generation code now. I'll keep it open until that's merged but maybe have a look and let me know if there's anything I missed.

has this been included in #3120? I'm failing to find references

@runcom
Copy link
Member Author

runcom commented Nov 29, 2022

gonna close this as it is included in #3130

@runcom runcom closed this Nov 29, 2022
@achilleas-k achilleas-k mentioned this pull request Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

Assignees
No one assigned
Labels
WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runcom @achilleas-k @schutzbot @yih-redhat