bib: integrate upload progress into main progressbar #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `Clear()` method on the progressBar so that we can clear subprogress easily. This is useful when switching from image building to image uploading, here we need a single progress again.
This commit improves the upload progress by integrating it with the new overall progress flow. After the building is done the upload will be part of the overall progress bar flow.
mvo5
force-pushed
the
progress3-integrated-upload
branch
from
22b4adb to
060ddbc
Compare
ondrejbudai
requested changes
Dec 19, 2024
| file, err := os.Open(filename) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot upload: %v", err) | ||
| } | ||
| defer file.Close() | ||
|
|
||
| keyName := fmt.Sprintf("%s-%s", uuid.New().String(), filepath.Base(filename)) | ||
| fmt.Fprintf(osStdout, "Uploading %s to %s:%s\n", filename, bucketName, keyName) | ||
| pbar.SetMessagef("Uploading %s to %s:%s\n", filename, bucketName, keyName) |
There was a problem hiding this comment.
Can we have a separate message for the registering step? See lines 76-79. Note that the AMI id should be printed to stdout, so people can use bib in scripts. Other messages probably don't belong to stdout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #743