-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress: auto-select progress based on the environment #765
Conversation
which was motivated by bootc having progress too. (And that relates to the larger overlap/duplication/desire-to-bridge between bootc progress and osbuild progress in containers/bootc#921 (comment) ) |
Thanks! Uh, that is rather embarrassing, I may indeed have just written my integration test incorrectly (had forgoten about -t) . I'm an idiot. Well, I guess it's good, it makes things easier. |
c6c9f84
to
03515f2
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
pylint seems to be complaining in the integration tests. Can you take a look, Michael? |
This commit adds automatic progress bar selection based on checking if we run on a terminal or not. When running on a terminal we use the nice "terminalProgressBar". If that is not set we assuem we run in a script or CI/CD environment and select plainProgressBar. Thanks Colin for the hint about the bad integration test.
03515f2
to
fd3e60d
Compare
This commit adds automatic progress bar selection based on checking
if we run on a terminal or not. When running on a terminal we use
the nice "terminalProgressBar". If that is not set we assuem
we run in a script or CI/CD environment and select plainProgressBar.
Thanks Colin for the hint about the bad integration test.