Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving accessibility for cookie consent dialog #892

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Improving accessibility for cookie consent dialog #892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af7de94
Changing role=button elements that should be buttons to <button> in p…
bamadesigner Nov 6, 2021
ee1cfe6
Removing role=button from <a> elements that are links, not buttons, i…
bamadesigner Nov 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/options/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,17 @@ export default {
message:
'<span id="cookieconsent:desc" class="cc-message">{{message}}</span>',
messagelink:
'<span id="cookieconsent:desc" class="cc-message">{{message}} <a aria-label="learn more about cookies" role=button tabindex="0" class="cc-link" href="{{href}}" rel="noopener noreferrer nofollow" target="{{target}}">{{link}}</a></span>',
'<span id="cookieconsent:desc" class="cc-message">{{message}} <a aria-label="learn more about cookies" class="cc-link" href="{{href}}" rel="noopener noreferrer nofollow" target="{{target}}">{{link}}</a></span>',
dismiss:
`<a aria-label="dismiss cookie message" role=button tabindex="0" class="cc-btn cc-${statusDismiss}">{{dismiss}}</a>`,
`<button aria-label="dismiss cookie message" class="cc-btn cc-${statusDismiss}">{{dismiss}}</button>`,
allow:
`<a aria-label="allow cookies" role=button tabindex="0" class="cc-btn cc-${statusAllow}">{{allow}}</a>`,
`<button aria-label="allow cookies" class="cc-btn cc-${statusAllow}">{{allow}}</button>`,
deny:
`<a aria-label="deny cookies" role=button tabindex="0" class="cc-btn cc-${statusDeny}">{{deny}}</a>`,
`<button aria-label="deny cookies" class="cc-btn cc-${statusDeny}">{{deny}}</button>`,
link:
'<a aria-label="learn more about cookies" role=button tabindex="0" class="cc-link" href="{{href}}" rel="noopener noreferrer nofollow" target="{{target}}">{{link}}</a>',
'<a aria-label="learn more about cookies" class="cc-link" href="{{href}}" rel="noopener noreferrer nofollow" target="{{target}}">{{link}}</a>',
close:
'<span aria-label="dismiss cookie message" role=button tabindex="0" class="cc-close">{{close}}</span>',
'<button aria-label="dismiss cookie message" class="cc-close">{{close}}</button>',
categories: '<ul class="cc-categories">' +
categories.map( ( category, index ) =>
`<li class="cc-category">
Expand Down