Add profile for unattended installation with lvm #20859
Conversation
chcao
force-pushed
the
add_unattended_lvm
branch
from
d0d632a to
23cd1dc
Compare
|
In general, LGTM, for powerVM and s390x, please check the current unattended test to run VR, yaml schedule should be different. |
chcao
force-pushed
the
add_unattended_lvm
branch
from
23cd1dc to
1e60d7e
Compare
Thanks for review. I added a yaml file for s390x. For ppc64le, the schedule is the same the x86_64 and aarch64: |
For s390x, it blocked by bsc#1234264. For powerVM, VNC is not supported for now, this test will fail same as unattended test. In fact, the unattended test should follow s390x to run puppeteer test to match the finish of installation. |
data/yam/agama/auto/lvm_sle.jsonnet
Outdated
| "chroot": true, | ||
| "body": ||| | ||
| #!/usr/bin/env bash | ||
| zypper rm openssh-server-config-rootlogin |
There was a problem hiding this comment.
Can you please double confirm if this package is installed in target system?
data/yam/agama/auto/lvm_sle.jsonnet
Outdated
| @@ -0,0 +1,36 @@ | |||
| { | |||
There was a problem hiding this comment.
we are planning to rename the rest of profiles, please use, sle_lvm
schedule/yam/agama_auto_lvm.yaml
Outdated
| @@ -0,0 +1,14 @@ | |||
| --- | |||
There was a problem hiding this comment.
we should stop using auto due to it is confusing, and use _unattended_
| @@ -0,0 +1,16 @@ | |||
| --- | |||
| @@ -0,0 +1,16 @@ | |||
| --- | |||
| name: agama unattended lvm | |||
There was a problem hiding this comment.
please file a ticket to think about how to unify in single yaml agama_auto_lvm.yaml and agama_auto_lvm_s390x.yaml (with new names of course) so we can avoid this repetition in the future, remark what is different.
|
For powerVM test, please base on this unattended test https://openqa.suse.de/tests/16332850# to run VR, and later after PR merged add the test suite. |
chcao
force-pushed
the
add_unattended_lvm
branch
from
1e60d7e to
37b890c
Compare
Add profile for unattended installation with lvm.
chcao
force-pushed
the
add_unattended_lvm
branch
from
37b890c to
1935e2d
Compare
Add profile for unattended installation with lvm.