-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom form_post response writer #731
base: master
Are you sure you want to change the base?
feat: add custom form_post response writer #731
Conversation
Levko Burburas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bdd3e0d
to
cce9574
Compare
@aeneasr |
Hey, open to get this merged - there are just more things that have a higher priority on my list right now :( Was this closed on purpose? |
I suspect maybe because of bc43abc since his may have conflicted and he's going to open another PR. Main reason I opened that was to avoid potential conflicts down the line with unrelated PRs. |
Oh, I thought that this PR went unnoticed. |
Please rebase this PR. Currently it contains extra commits/changes. |
The current interface
FormPostHTMLTemplateProvider
only allows rendering a customform_post
template. But there is no way to pass extra template variables to be used in the template.This pull request adds the ability to assign a custom form_post response writer.
Related Issue or Design Document
Implements a new feature, issue reference #730
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments
I couldn't manage to pass
nancy/test
, it claimsbut I can't figure out which package uses this dependency.