Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream compile-time selection of wrappers #47

Open
kunaltyagi opened this issue May 22, 2018 · 2 comments
Open

Downstream compile-time selection of wrappers #47

kunaltyagi opened this issue May 22, 2018 · 2 comments

Comments

@kunaltyagi
Copy link
Contributor

Is there a method we can leave the selection of wrappers to downstream? The simplest idea is making the wrappers headers only (I don't know how feasible that is)

Right now, selection of wrappers requires modification in the FindMATRIX.cmake file. This is a slight issue because using Eigen as backend requires a separate dependency management.

@toeklk
Copy link
Collaborator

toeklk commented May 25, 2018

Could you elaborate a little bit on what you mean with downstream. From your first paragraph, I understand that "user" of the installed BFL library could select a matrix/rng library.
Inlining the code would then partially do the job I suppose (but you wouldn't have some 'nifty' stuff such as the pkgconfig configuration that tells you with which libraries to link).

I'm afraid I don't understand very well what you mean with your second paragraph though?

@kunaltyagi
Copy link
Contributor Author

Sorry for the weird usage. I'll elaborate a bit 😅
I'm using BFL with ros, and ros distributes BFL compiled with Boost. This creates subtle bugs in development which are just a wee bit irritating

@toeklk toeklk added the wrappers label Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants