Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile warnings MSVC142/143 #22

Open
mrboojum opened this issue Jul 7, 2022 · 1 comment
Open

Compile warnings MSVC142/143 #22

mrboojum opened this issue Jul 7, 2022 · 1 comment

Comments

@mrboojum
Copy link

mrboojum commented Jul 7, 2022

When sorting 64 bit ints I got some warnings on windows/MSVC142
pdqsort\pdqsort.h(278,26): warning C4244: 'initializing': conversion from '__int64' to 'int', possible loss of data ...
pdqsort\pdqsort.h(143,1): warning C4244: '+=': conversion from '__int64' to 'int', possible loss of data

I can resolve them locally by replacing int with int64
@orlp
Copy link
Owner

orlp commented Jul 7, 2022

I think you have an outdated version of pdqsort.h, can you update it and see if that resolves it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orlp @mrboojum