Mission Pinball Framework
MPF 0.56 doesn't work with P(3)-Roc #80
Replies: 7 comments 28 replies
-
|
Try following the steps here: https://docs.missionpinball.org/en/stable/hardware/multimorphic/hardware_drivers.html Shot in the dark, but since you upgraded python, do you need to reinstall the multimorphic stuff again. |
Beta Was this translation helpful? Give feedback.
-
|
Gave it a try, but the issue still persists. Windows Device Manager does show the P3-Roc as connected. I still suspect MPF or Python does cause this problem. Is there a way to downgrade to MPF0.55? Until the Devs resolve the current issue. |
Beta Was this translation helpful? Give feedback.
-
|
MPF has always used a special version of the p-roc drivers on Windows.
Unfortunately, Multimorphic has never supported or created a Python 3
compatible driver library. One was created specifically for MPF a long time
ago. The problem has been building that driver for Windows. The way it is
now, compiling and building the p-roc driver has been a difficult manual
process for each new version of Python. I managed to do this for the
project a few years ago when Python 3.6 was released, but the project
didn't work for Python 3.7+ and I haven't had any time to try to figure it
out (and I don't own any p-roc or p3-roc boards to test it). MPF (or really
someone connected to Multimorphic) needs to maintain a set of Python 3
compatible drivers (or set something up using github actions to
automatically build).
Bottom line, the problem is not specifically with MPF 0.55 but with not
having the Windows p-roc drivers for newer versions of Python 3 (and not
having anyone to create and maintain them).
Quinn
…On Sat, Feb 18, 2023 at 4:11 AM Midway-Man ***@***.***> wrote:
Gave it a try, but the issue still persists. Windows Device Manager does
show the P3-Roc as connected. I still suspect MPF or Python does cause this
problem.
Is there a way to downgrade to MPF0.55? Until the Devs resolve the current
issue.
—
Reply to this email directly, view it on GitHub
<#80 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6GRTPB7JFS4US25SNIZYLWYCU7ZANCNFSM6AAAAAAU7LWC6Y>
.
You are receiving this because you are subscribed to this thread.Message
ID: <missionpinball/missionpinball/repo-discussions/80/comments/5017865@
github.com>
|
Beta Was this translation helpful? Give feedback.
-
|
The one I built is definitely importable in Python. Do you want me to send it to you to try (and the VC++ project)? If so, send me an email (my address is in the mpf AUTHORS file). I can send you a download link. Quinn |
Beta Was this translation helpful? Give feedback.
-
|
First off... everyone that uses multimorphic hardware owes Quinn many many beverages of his choosing! I was able to get it working with the file Quinn sent me. I had two computers side by side with the same code, one running 0.55 and python 3.8 and one running 0.56 and python 3.9. Both were able to connect, run hardware scan, and register switches coils, autofire coils, etc. So as far as I can test with my current hardware it appears to be working as expected!!! I will go through to see why I couldn't get it working on my build and get clear documentation written so that this can easily be supported in the future as versions increment. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Sorry, work went to hell last week and got tied up. I was able to get the 64-bit compiled (and matched what Quinn had). Then got the 32-bit compiled as well (not sure if it's really needed, but to be consistent if people still have 32-bit machines). I will get those pushed up so that they can be included for others going forward. I will be doing that shortly. @qcapen I went ahead and compiled 3.10 and 3.11 off their respective Python while I was at it and can do 3.12 when it comes out in a few months. Do you see any issue of pushing up those files so that they are there when MPF moves to future versions of Python? Also, any thoughts about pushing up the VS Project with some instructions? If you have the project, with my three changes that need made for deployment of a new version for both 32 and 64, it's something that anyone else could pick up at this point until/if its automated. Would that be a new project all together that houses it? If so, should that be owned by Mission Pinball? |
Beta Was this translation helpful? Give feedback.
-
|
Glad you got everything working. Feel free to add the 3.10 and 3.11 (and 3.12 when it becomes available) to the mpf project. That should buy quite a bit of time for compatibility with future releases. The eventual goal would be to build the Windows binaries in the Mission Pinball version of the pypinproc repository using GitHub actions. For now the manual build should suffice. I suppose the VS project could be posted in another missionpinball GitHub repo with modification instructions, although if any of the pinproc or libpinproc code changes it would have to be manually updated (I'm not sure if the FTDI source can be included in our repo or whether that would have to be downloaded and added manually to the project depending on the license). Perhaps it is sufficient enough to just post very detailed instructions somewhere to recreate the project. |
Beta Was this translation helpful? Give feedback.
-
|
I don't use a P-ROC so I can't comment on whether it would work on Mac or Linux under Python 3.7+, but for your other question, all the old documents are still available. On the docs.missionpinball.org site, in the lower left corner, you can click the green version text. (Probably "v:stable" or "v:latest" in the docs you're looking at.) Then from there you should see links to 0.55 and prior docs versions. If you're part of the PinDev Slack group (I think there's where P-ROC/P3-ROC support is nowadays), you can try posting there to see if anyone is willing to see why the P-ROC drivers don't compile for Python 3.7+, though I believe most P-ROC/P3-ROC users use PyProcGameHD/SkeletonGame which runs on Python 2.x so you might not have luck there. Also as for adding a warning to the docs, the MPF docs are also open source, so if you're feeling adventurous and want to make this change to the docs yourself, you can click the "Edit on GitHub" link in the upper right corner of any MPF docs page to make changes to that document page, and if you need more detailed instructions, there's a topic called "Contributing to MPF docs" in the table of contents all the way at the bottom under "About MPF". |
Beta Was this translation helpful? Give feedback.
-
|
@toomanybrians I would argue the comment about P-Roc (P3) not using MPF would not be accurate. There seem to be a ton of people using that, and more that I personally know than other "off the shelf" if you exclude OPP. All that to say the previous maintainers (Jan, Quinn, Anthony) managed and supported all platforms. I know your work and updates to text has made it clear that MPF maintains itself, and all platforms must maintain their plugins. If that's incorrect, please correct me. With that said, has there been any effort to communicate that to the platform hosts? Obviously you handle FAST, but has Gerry/Ocean been made aware? Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
@atummons I've contacted Gerry today, maybe he has a solution. Let's wait and see. ;) In the meantime I finished working on the CAD of Whitewood #2. Time well spend :D |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for doing that. Fingers crossed! |
Beta Was this translation helpful? Give feedback.
-
|
Ah, ok good to know @atummons that there are lots of P-ROC Windows MPF users. Makes sense that I wouldn't know since I don't use a P-ROC or Windows myself. Hopefully we hear back from one of them to update the Windows drivers! 🤞Or maybe they're just using older versions of MPF which are compatible with Python 3.6 or older? Anyway let's see what Gerry comes back with. Yes, you're right about me asking for individual platforms to maintain their own platform interfaces. (Or for them to find someone to do it.) I'm still looking for someone to own the maintenance for the MPF project in general. I don't have the time or skill that Jan did (the new installers alone took me like 2 months) so that's why I'm trying to set the expectations in the docs that no one is really in charge, so people should set their expectations accordingly. But if there's a better approach, I'm open to it! |
Beta Was this translation helpful? Give feedback.
-
|
@toomanybrians all sounds great! I like to contribute as I can and understand the ask, but I am certainly not knowledgeable enough to review code. As long as we have someone who can, even periodically, review community contributions, I think we're in good shape! |
Beta Was this translation helpful? Give feedback.
-
|
Bump. It's not just windows, its Ubuntu also. I wonder about Mac. |
Beta Was this translation helpful? Give feedback.
-
|
Bummer… Thanks for sharing this info. Unfortunately I haven’t got any reply from Multimorphic. Will try another approach. |
Beta Was this translation helpful? Give feedback.
-
|
I was able to get it working under ubuntu 20 today. In my case there were a couple hangups. First I went with ubuntu 20 because it defaults to Python 3.8. Then I ran the installer scripts one line at a time from the command line. I ran into a minor problem with a kivi version but was able to set it to the correct version when it initially failed. I believe I used the suffix for version ==0.1.1 Then I had to alter the last command of the install-proc script from sudo python3 setup.py install to python3 setup.py install --user save the script give it the sudo chmod + x and run it. After that I had MPF connecting to Multimorphic hardware. Given my success, I think I can also get it to work with Ubuntu 22 by setting up a python virtual environment for python 3.8. But that's a problem for another day. |
Beta Was this translation helpful? Give feedback.
-
|
You are using Python 3.8? Which version of MPF do you use? |
Beta Was this translation helpful? Give feedback.
-
|
3.9 is only a requirement on Windows. Brian or someone else in the know would have to explain why. I looked at changes from 3.8 to 3.9 and don’t see any dependencies that require it, but I’m certain I just don’t fully understand it.Sent from my iPhoneOn Apr 26, 2023, at 10:25 AM, Midway-Man ***@***.***> wrote:
You are using Python 3.8? Which version of MPF do you use?
Didn’t the instructions say MPF 0.56 will only work with Python 3.9?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Files have been added, nice work everyone. |
Beta Was this translation helpful? Give feedback.
-
Just updated my machine from MPF0.55 Python3.8 to MPF0.56 Python3.9
But unfortunately my game no longer works. It crashes at startup. No changes have been made to the code itself.
When i start MPF with virtual hardware -X my code runs fine. The issue must be related to one of the new versions of MPF or Python. Unfortunately I am not an expert, so it would be nice if one of the DEVs could help my out.
That's part of the log file.
2023-02-17 12:48:39,148 : INFO : Machine : Initialise MPF.
2023-02-17 12:48:39,221 : ERROR : Machine : Failed to initialise MPF
Traceback (most recent call last):
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\platforms\p_roc_common.py", line 31, in
import pinproc
ModuleNotFoundError: No module named 'pinproc'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\platforms\p_roc_common.py", line 39, in
from mpf.platforms.pinproc.windows import pinproc
ImportError: cannot import name 'pinproc' from 'mpf.platforms.pinproc.windows' (unknown location)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\core\machine.py", line 679, in initialise_mpf
raise init.exception()
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\core\machine.py", line 246, in initialise
await self.initialise_core_and_hardware()
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\core\machine.py", line 232, in initialise_core_and_hardware
self._load_hardware_platforms()
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\core\machine.py", line 479, in _load_hardware_platforms
self.add_platform(hardware_platform)
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\core\machine.py", line 613, in add_platform
self.hardware_platforms[name] = hardware_platform(self)
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\platforms\p_roc.py", line 44, in init
super().init(machine)
File "C:\Users\Pinball.local\pipx\venvs\mpf\lib\site-packages\mpf\platforms\p_roc_common.py", line 180, in init
raise MpfRuntimeError('Could not import "pinproc". Either the library is not installed or is missing '
mpf.exceptions.runtime_error.MpfRuntimeError: Runtime Error in P-Roc: Could not import "pinproc". Either the library is not installed or is missing some of its dependencies. Check the install instructions for your OS in Multimorphic section of the MPF docs. You can run mpf with "-X" to use virtual hardware in the meantime. Error Code: RE-P-Roc-3 (https://docs.missionpinball.org/en/0.56/logs/RE-P-Roc-3.html)
Thanks in advance for helping us!
Beta Was this translation helpful? Give feedback.
All reactions