New commit details page (public beta) feedback #139005
Replies: 322 comments 414 replies
-
My first reaction to the new page was: What is happening now!?! My second impression was: why is everything 50% bigger, did I Ctrl+Scroll to zoom by accident? And my third was: where are the diff count squares? Also I just found the first bug: when having text selected and trying to extend that selection with shift, that no longer works. Also I was just searching a bit for a commit message because since it is now completely grey, I kinda missed it. |
Beta Was this translation helpful? Give feedback.
-
I personally dislike the new page's design. |
Beta Was this translation helpful? Give feedback.
-
I cant see now how my files have been changed by size, thats not good |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
The problem (as mentioned by others), isn't the scaling, the scaling is actually the same as before. The issue is the If this is for accessibility purposes, then it should be it's own feature preview or option that the user can toggle. Another issue that's not mentioned yet is that commits with really long descriptions now have a "Show more" button instead of just showing the full description. If I'm clicking on a commit, I probably want to read the description. Please don't make me click multiple times. The text could also be made brighter and easier to read as it was before. See with this example commit: mpv-player/mpv@d2f3b66 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Honestly, I liked the old design better. I hope there will be an option to switch between them. |
Beta Was this translation helpful? Give feedback.
-
... I can't right click to copy/paste the code? |
Beta Was this translation helpful? Give feedback.
-
The new design seems to struggle with tab indentation in files. For the sake of completeness I'll mention that the below screenshots are using 4-space tabs in my user settings but the effect in the new design is the same with the default of 8. |
Beta Was this translation helpful? Give feedback.
-
The default-collapsed commit text seems to utterly miss the point of the commit details page. It's also much harder to read – the previous page used #1f2328 on #f1f8ff, which has an excellent contrast of Lc 98.0, but the new page uses #59636e on #fff which works out to only Lc 80.5, which is well below the preliminary APCA Bronze threshold of Lc 90. In conjunction with the smaller font size (was 13px, now 12px), the commit text is now very difficult for me to read. Duplicating the first line of the commit text (once in the big heading, once in the monospace body) seems a bit odd: Lastly, the line-height of the code is uncomfortably large, I really hope you don't intend to use this style across the whole website going forwards. |
Beta Was this translation helpful? Give feedback.
-
When you start writing a comment, the textbox now expands off-screen: so you have to scroll down again to see the button to submit the comment now. If the comment box were not collapsed by default, this would be solved. The page also doesn't seem to have the standard GitHub footer, which doesn't help. On wide screens (and by "wide" I mean "16:9 1440p"), having to mouse all the way over to the right-hand side to add a comment makes it really hard to see which line you're commenting on (unless you want to open the dialog, check the line number on the right (which says "R" for some reason?), pull your eyes back to the left-hand side to check the line number there, and try again if you aimed wrong): And the tooltips on the comment widget buttons ("Heading", "Bold", etc.) appear to have been dropped, which sucks. |
Beta Was this translation helpful? Give feedback.
-
Links to diffs for specific ranges no longer work. The page does not correctly focus the view on the range present in the URL (for example, the URL ending with |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
The commit details only show a fraction of the files changed, both in the directory viewer and the diff viewer. Furthermore, the search box does not work reliably. I know for a fact that I changed a specific file in that commit, but it does not appear in either the directory view or the diff view. |
Beta Was this translation helpful? Give feedback.
-
Is anyone else seeing this? As of a 2024-11-29, the "Comments" section of the commit details page will not display. It simply spins with a greyed-out template of a comment and shows Here's an example where I see everything but the comments (you can see where I commented directly via web, but then it stopped and I had to respond via email): Tried it on Fedora Firefox, Ubuntu Firefox, Win10 Firefox, Chrome, Opera and Edge. Same behavior everywhere. |
Beta Was this translation helpful? Give feedback.
-
There should be a link from the commit details page directly to any Pull Requests which include that commit. This is something that I do all the time and have to look up online how to do it every time. |
Beta Was this translation helpful? Give feedback.
-
The buttons to expand a diff upward/downward seem to be broken. It's the |
Beta Was this translation helpful? Give feedback.
This comment has been minimized.
This comment has been minimized.
-
I'm still enormously missing a direct link to the original and patche files, as well as a direct link to download the patch in git-archive format, with ordered numbers (because fiddling with the URL, in addition to being a pain, also produces patches named after their hash, making it hard to re-apply them in order). This is very often needed, every time you have to edit a patch before applying it (to fix typos, add missing tags etc). |
Beta Was this translation helpful? Give feedback.
-
My commit has Azure Kubernetes Service abbreviated to AKS. This got autocorrected to ASK (ask) everywhere! |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hello Github Developers, we got some issue with dates of old commits (for today is Mon 9 Dec 2024), here is example: |
Beta Was this translation helpful? Give feedback.
-
Images are clipped and jump around: output.mp4 |
Beta Was this translation helpful? Give feedback.
-
Going back on chrome on iPhone doesn’t go to the commit history. Chrome on iPhone badly implements a weird heuristic to figure where to go back. It would be nice to have a button to go back to the list of commits for the branch that took me there or to fix the history to work with google chrome on iPhone |
Beta Was this translation helpful? Give feedback.
-
Hey has anyone contacted me ??? i have not once been in discussion with anyone!!!! SSH login On Wednesday, December 11, 2024 at 02:27:29 PM CST, almao ***@***.***> wrote:
i would dude. b id believe that might be reverse engineering? 3rd patries etc... ive been in alfpa and some beta. Im SHURE one of the Githubstaff would help you out. U mind explaining whats up btw? was away for an frew hours
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
ای که بر مرکب تازنده سواری هشدار
خر مسکین سوخته در آب گل است
…-------- پیام نخستین --------
از: DARIK R PRESCOTT ***@***.***>
ارسال: ۱۲ دسامبر ۲۰۲۴ ۰۶:۰۶:۵۹ (GMT+03:30)
به: community/community ***@***.***>
رونوشت به: ***@***.***" ***@***.***>, Manual ***@***.***>
موضوع: Re: [community/community] New commit details page (public beta) feedback (Discussion #139005)
Hey has anyone contacted me ??? i have not once been in discussion with anyone!!!! SSH login On Wednesday, December 11, 2024 at 02:27:29 PM CST, almao ***@***.***> wrote:
i would dude. b id believe that might be reverse engineering? 3rd patries etc... ive been in alfpa and some beta. Im SHURE one of the Githubstaff would help you out. U mind explaining whats up btw? was away for an frew hours
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
--
Reply to this email directly or view it on GitHub:
#139005 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
A new version of the commit details page is now available in public beta! This new page, which is enabled by default, lets you quickly understand and navigate the changes in a commit with improvements to filtering, commenting, and keyboard navigation!
What's new 🎉
Here are a few of the noteworthy changes:
up
anddown
keys on your keyboard. A new context menu also makes it easier to comment, copy, and select.To opt out of the preview, go the Feature Preview dialog on your profile, select New Commit Page, and click Disable.
Let us know what you think!
Investigating 🟨
Things we are discussing and investigating internally (and we welcome your feedback on):
Known issues 🔴
#diff-e727e4R4-R7
).
) appears before file name in header above diff.gitattributes
not presented as generated)@
mention menu does not appear when adding/editing inline commentsIn progress 🧡
(updates coming)
Recent fixes and enhancements ✅
Week of September 16:
Copy
menu option not appearing for some users ✅Week of September 23
Screen.Recording.2024-09-26.at.11.34.46.AM.mov
More about compact line height
* Compact line height user setting 🆕: * **What's our plan?** Based on your feedback about the height of diff lines in the new parge, we are adding a user setting under the ⚙️ that you can enable if you want more compact lines. When enabled, the height of diff lines will be `20px` (same as the classic commit details page), otherwise (and by default) they will be `24px`. * **Why a user setting?** It is important that this (and every) page on GitHub is accessible to everyone. [WCAG recommends a minimum of `24x24px` for click targets](https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html) because _some people with physical impairments cannot click small buttons that are close together_. The avatar (which appear when there are comments on a line) and button to add a comment are both important click targets on the line, which is why the default height of the line is 24px. We recognize that some users prefer (and are able to interact with) more compact lines and click targets, which is why we are introducing a user setting.
Beta Was this translation helpful? Give feedback.
All reactions