Clerk
Clerk Core 2 Beta Feedback Thread #2900
Replies: 12 comments 40 replies
-
|
Great work! The migration CLI was very helpful. I noted, though, that the type |
Beta Was this translation helpful? Give feedback.
-
|
It should be available from |
Beta Was this translation helpful? Give feedback.
-
|
Indeed, thanks for the hint. The only issue is now that two different versions of
|
Beta Was this translation helpful? Give feedback.
-
|
Hello everyone, We decided not to export these in v5 as these describe the DTOs used by the package internally and most of the time people are using the instantiated resources from utils like If using webhooks, the standard approach is the following import type { WebhookEvent } from "@clerk/nextjs/server"
const handler = req => {
const evt = req.body.evt as WebhookEvent;
switch (evt.type) {
case 'user.created':
// evt.data is of type UserJSON
}
}In the snippet above, It seems that our assumption was wrong - people do want to use these directly so we'll get this changed as soon as possible (Monday 11 Mar is a realistic release date for the next beta version). It'd be great if you could share your use case so we understand the need better - is there maybe another API we can provide here to avoid the need to use these helpers directly? Many thanks for the report :) I'll update the thread here once the fix is out. |
Beta Was this translation helpful? Give feedback.
-
|
@nikosdouvlis, thanks! Any plans to also export |
Beta Was this translation helpful? Give feedback.
-
|
Hi @nikosdouvlis, we have a couple of webhooks attached and don't want to clutter the main handler file. Therefore, we keep the individual action handlers in separate files. They thus need the typed |
Beta Was this translation helpful? Give feedback.
-
|
Upgrading to Core 2 was a breeze, really enjoying all the changes so far! I am running into an issue with sign-ups through email. When I sign up via email through my dedicated sign-up page, I'm redirected to the route 
Is there a way to use a Clerk component to show the verification steps? or should it have kept me on EDIT export default function SignUpPage() {
return (
<>
<SignUp routing="virtual" />
</>
)
}`` |
Beta Was this translation helpful? Give feedback.
-
|
(https://beta.clerk.com/docs/upgrade-guides/core-2/nextjs#middleware-auth-config) I think you guys should definitely fix this to be admin instead of org admin, or at least update the comment. It caused me to waste time to figure out that if i switched to a org that i was not a admin to i lost admin access to all my true admin access. I was using a org switcher in my admin area so it really made for a runaround. What's more confusing is it results in a 404 error. I think most people were using it middleware to protect normal account admin which is far more dangerous. |
Beta Was this translation helpful? Give feedback.
-
|
@emersonh-xyz Hello there, I'm forwarding this to the engineering team but I'd like some more details if possible:
@amp127 |
Beta Was this translation helpful? Give feedback.
-
|
Update regarding the 404 code - vercel/next.js#63302 introduces a NextJS Unfortunately, we cannot delay the Core-2 GA release until these are merged so Core-2 will use |
Beta Was this translation helpful? Give feedback.
-
|
Loving the beta!🙏 We are daring, and use it in production in an app currently. When can we expect the official release? |
Beta Was this translation helpful? Give feedback.
-
|
The Beta version of Clerk is very easy to use for me. I found the following type importing error in 
|
Beta Was this translation helpful? Give feedback.
-
|
Hello @nakanoasaservice, glad to hear you like the beta so far :) |
Beta Was this translation helpful? Give feedback.
-
|
This is fixed and will be deployed with our next release, thanks for reporting! |
Beta Was this translation helpful? Give feedback.
-
|
I posted an issue here about a problem with the Reproduction: git clone https://github.com/itsMapleLeaf/clerk-beta-remix-vercel-bug
cd clerk-beta-remix-vercel-bug
npx vercel deployThe app crashes at runtime with the following error: The reproduction here is specifically in the case of Vercel + Remix, but I think the root of the issue is the Here's what happens:
If possible, the code should change to not rely on a class whose identity is locked at definition time. |
Beta Was this translation helpful? Give feedback.
-
|
👋🏻 @itsMapleLeaf |
Beta Was this translation helpful? Give feedback.
-
|
It works! Love to see it 👏 Thanks y'all! Can finally remove that awful workaround I had 😂 |
Beta Was this translation helpful? Give feedback.
-
|
Great, glad to see this is resolved :) Thanks for reporting in the first place |
Beta Was this translation helpful? Give feedback.
-
|
Hi @itsMapleLeaf 👋
|
Beta Was this translation helpful? Give feedback.
-
|
A working solution, hopefully it will be useful. |
Beta Was this translation helpful? Give feedback.
-
|
I am having issues with the redirect after sign-in/sign-up. I am always taken to I have set redirects in the account portal, although the redirect_url query param is also set. Is this a known issue? |
Beta Was this translation helpful? Give feedback.
-
|
With NextJS? Did you specify the environment variables? E.g.: NEXT_PUBLIC_CLERK_SIGN_IN_URL="/sign-in"
NEXT_PUBLIC_CLERK_SIGN_UP_URL="/sign-up"Also, I think there might be a |
Beta Was this translation helpful? Give feedback.
-
|
Yes, i have tried setting env-variables, setting it in the account-portal, and setting it in the middleware like this export default clerkMiddleware({
afterSignInUrl: "/admin",
afterSignUpUrl: "/admin",
}); |
Beta Was this translation helpful? Give feedback.
-
|
It appears that the types SignedInAuthObject and SignedOutAuthObject are no longer being exported. These types are referenced in the documentation for TRPCContext available here: https://clerk.com/docs/references/nextjs/trpc. |
Beta Was this translation helpful? Give feedback.
-
|
@DennizSvens, would you also please let us know if you have a need where the |
Beta Was this translation helpful? Give feedback.
-
|
I believe the use case for having this type would be to allow access to "internals" of the tRPC context (for testing/SSG Helpers). Can't say I've used this myself but perhaps others do.
|
Beta Was this translation helpful? Give feedback.
-
|
Here's another example where the types /**
* Get auth session. Contains info about current organisation.
*
* @param request Express request object
* @returns Auth object - SignedInAuthObject, SignedOutAuthObject or null
*/
async getSession(request: Request): Promise<SignedInAuthObject | SignedOutAuthObject | null> {
const requestState = await this.getRequestState(request);
const auth = requestState.toAuth();
return auth;
} |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to actually get this type now? Or is it purely for internal uses? I am unsure what to replace the type with during this upgrade. Edit: I guess the question is more about if the import is allowed to be updated to |
Beta Was this translation helpful? Give feedback.
-
|
I resolved this by using the import { getAuth } from "@clerk/nextjs/server";
// ...
type ContextType = {
auth: ReturnType<typeof getAuth>;
};Very useful mechanism to get types for functions that are part of the public interface but aren't actually exposed! |
Beta Was this translation helpful? Give feedback.
-
|
Hey, The Clerk Core 2 Beta 41 so far seems very stable and performant. Great job team, you've done an awesome job on removing technical debt and improving performance overall! I'm very satisfied with Clerk. :) One "dumb" question: I've looked at the beta docs and there's no documentation on how to chain multiple middlewares together. Only on how to add one middleware (see: https://beta.clerk.com/docs/references/nextjs/clerk-middleware#combining-middleware) My problem is simple: I have a Content-Security Policy (CSP) middleware and an I18N middleware. I need them both to be online. How can I chain the middlewares? Example code: // file: middleware.ts
import {clerkMiddleware as authMiddleware, createRouteMatcher} from "@clerk/nextjs/server";
...
export default authMiddleware((auth, req) => {
if (isProtectedRoute(req)) {
auth().protect();
}
return cspMiddleware(req);
// ^--- here I'm using my csp middleware, but I want to use both this and my i18n middleware.
});I'm using Next.JS btw. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I've added the middleware.ts file into the src folder as taken from the blog article: The auth seems to work as expected but I'm getting the following error in the console:
Any ideas as to why it's working but still giving this error. note: This is a t3 app |
Beta Was this translation helpful? Give feedback.
-
|
We're happy to announce that Core 2 is now Generally Available (GA) 🎉 Thanks for giving it a try - if you have any further feedback, feel free to leave it here or open an issue with a reproduction. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
More or less same problem as @itsMapleLeaf posted recently, I get the same problem with a NestJS application. error TypeError: Failed to parse URL from /protected
at new Request (node:internal/deps/undici/undici:6110:19)
at new ClerkRequest (/home/clerk5-nestjs-bug/node_modules/@clerk/backend/src/tokens/clerkRequest.ts:24:5)
... 6 lines matching cause stack trace ...
at canActivateFn (/home/clerk5-nestjs-bug/node_modules/@nestjs/core/router/router-execution-context.js:135:59)
at /home/clerk5-nestjs-bug/node_modules/@nestjs/core/router/router-execution-context.js:42:37 {
[cause]: TypeError: Invalid URL
at new URL (node:internal/url:796:36)
at new Request (node:internal/deps/undici/undici:6108:25)
at new ClerkRequest (/home/clerk5-nestjs-bug/node_modules/@clerk/backend/src/tokens/clerkRequest.ts:24:5)
at createClerkRequest (/home/clerk5-nestjs-bug/node_modules/@clerk/backend/src/tokens/clerkRequest.ts:72:54)
at authenticateRequest (/home/clerk5-nestjs-bug/node_modules/@clerk/backend/src/tokens/request.ts:66:57)
at Object.authenticateRequest2 [as authenticateRequest] (/home/clerk5-nestjs-bug/node_modules/@clerk/backend/src/tokens/factory.ts:51:12)
at AuthService.authenticateRequest (/home/clerk5-nestjs-bug/src/auth/auth.service.ts:26:32)
at AuthGuard.canActivate (/home/clerk5-nestjs-bug/src/auth/auth.guard.ts:32:52)
at GuardsConsumer.tryActivate (/home/clerk5-nestjs-bug/node_modules/@nestjs/core/guards/guards-consumer.js:15:34)
at canActivateFn (/home/clerk5-nestjs-bug/node_modules/@nestjs/core/router/router-execution-context.js:135:59) {
code: 'ERR_INVALID_URL',
input: '/protected'
}
}The crash and reproduction is much the same, yet not with Remix or Vercel, but @itsMapleLeaf already posted some good thoughts on the problem. NestJS runs on express and there's an additional problem with @nikosdouvlis You fixed it last time, can you take a look at this as well? |
Beta Was this translation helpful? Give feedback.
-
|
My pleasure, happy to help! |
Beta Was this translation helpful? Give feedback.
-
|
BTW, in order to achieve the expected functionality, I thoroughly reviewed the source code of both |
Beta Was this translation helpful? Give feedback.
-
|
I am still running into this error from express just trying to pass in the request into the middleware. I have been reading everything I can find online but can't seem to get past this error. |
Beta Was this translation helpful? Give feedback.
-
|
For anyone still following this, you should be able to get around it now by using the |
Beta Was this translation helpful? Give feedback.
-
|
Hello everyone! Most of the code was taken from @clerk/express. Most likely, the creators forgot to add something similar for @clerk/backend. Code: |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I am getting this error, even though I am using catch-all route. Do you have some idea why it happens? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the report. Can you check if it resolves if you remove the (We'll treat as a bug if that's the case, just trying to narrow it down!) |
Beta Was this translation helpful? Give feedback.
-
|
Still the same :( Might it be the case that it's because of local environment? Setup: |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
Did you have a chance to look into this, @colinclerk. Thanks 🙏 |
Beta Was this translation helpful? Give feedback.
and others
-
On February 29th, we released the beta version of Clerk Core 2, a major update to all of our SDKs. If you have had the chance to try it out, please feel free to leave feedback here. Thank you so much!
Edit on April 19th: We've released Core 2 as GA. Learn more!
Beta Was this translation helpful? Give feedback.
All reactions