-
I have no idea what that means in approving a pull request. Apparently lore before my time. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
"Looks Good To Me", i.e. nothing obviously wrong, can be merged |
Beta Was this translation helpful? Give feedback.
-
I looked over the diffs. I didn't run the changed system or test it because it wasn't in system critical code or used in the development cycle (as would be for changes that affect the load/makefile/compile cycle (since we're developing on top of previous changes -- one of the risks of the residential style). |
Beta Was this translation helpful? Give feedback.
"Looks Good To Me", i.e. nothing obviously wrong, can be merged