Update to Typescript 5.3.3 and associated updates #7
vincentmarchetti
started this conversation in
Show and tell
Replies: 1 comment 1 reply
-
Had a look at the changes: I think it all looks fine 👍 can remove that thumbs test. I think you're right - probably a major version with all the dependency changes, specifically Typescript. (cc @edsilv) Is the 3D/scene work ready for experimenting now? I could have a look at adding a branch to https://github.com/iiif-commons/parser for basic support |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have forked the manifesto repository to support development of the API in handling 3D content. This development is being carried out by the IIIF 3D Technical Study Group. On cloning the IIIF-Commons/manifesto, and checking out the master branch, I found that on a fresh installation (fresh Node.js; fresh run of npm install ) there were several invalid or deprecated modules, and modules identified as vulnerable.
I created a branch "kshell-update-original-manifesto" in my repository https://github.com/vincentmarchetti/manifesto and updated the dependencies and configuration files, re-enabled the tests, and made a minor changes in one Typescript source code file, all described below and in the commit history. The result, at commit 9f709b0, Feb 10, is a package that builds without errors and runs the original suite of 200 tests with just one failed test. It's a significant change is some module versions, but if acceptable this can be submitted as a pull-request.
A summary of changes:
Updated the dependency on Typescript from 3.6.3 to 5.3.3
Replaced awesome-typescript-loader with ts-loader
update mocha (testing) from 2.2.4 to 10.2.0
updated typedoc (document generation) from 0.15 to 0.25.8
Restricted install dependency on module node-fetch to v2; the current v3 is incompatible with the manifesto typescript code
Several other module dependencies were updated as well.
Changed typescript source in in src/PropertyValue.ts. The javascript spread operator was throwing type errors. The spread operator was replaced by explicit iteration over lists.
All test cases were enabled. 203 passed, 1 failed, a method Sequence.getThumbs which is already marked in source as to-be deprecated.
Beta Was this translation helpful? Give feedback.
All reactions