Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORL-72] Add support for de-duplicating tags #72

Open
orels1 opened this issue Jul 3, 2024 · 1 comment
Open

[ORL-72] Add support for de-duplicating tags #72

orels1 opened this issue Jul 3, 2024 · 1 comment
Assignees
@orels1
Labels
feature Feature reqyuests Generator Created by Linear-GitHub Sync

Comments

@orels1
Copy link
Owner

orels1 commented Jul 3, 2024

Currently it is possible to define duplicate tags, e.g.

Tags {
  "RenderType" = "Opaque" "RenderType" = "Transparent"
}

While this doesn't cause issues for regular rendering - unity picks the last instance of the tag, it can cause issues with shader replacement and bakery, so duplicate tags should deduplicated and only the last instance should be set in the template

De-duplication should be done using the ShaderParser

From SyncLinear.com | ORL-72
@orels1 orels1 self-assigned this Jul 3, 2024
@orels1 orels1 added feature Feature reqyuests Generator Created by Linear-GitHub Sync labels Jul 3, 2024
@orels1
Copy link
Owner Author

orels1 commented Jul 3, 2024

This is included in the upcoming 6.4.0 release

orels1 added a commit that referenced this issue Jul 3, 2024
@orels1
added support for deduplicating shader tags, closes #72
b49fb82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orels1 orels1

Labels
feature Feature reqyuests Generator Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orels1