Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORL-67] Albedo channel select is selecting the wrong channel #63

Open
JotaPe opened this issue Jan 12, 2024 · 3 comments
Open

[ORL-67] Albedo channel select is selecting the wrong channel #63

JotaPe opened this issue Jan 12, 2024 · 3 comments
Labels
bug Something isn't working linear Created by Linear-GitHub Sync PBR Created by Linear-GitHub Sync Shaders Created by Linear-GitHub Sync
Milestone

Comments

@JotaPe
Copy link

JotaPe commented Jan 12, 2024

Describe the bug
Because of indexing being wrong, the albedo channel dropdown is selecting the wrong channel

To Reproduce
1 - Use the Standard Orels Shader
2 - Put a texture on the Albedo
3 - Select a channel

Expected behavior
Select the correct channel for albedo colors

Screenshots

image

Texture with this blue channel

image

Blue Channel selected on material, but instead is selecting the alpha channel

Environment:

  • OS: Windows 10
  • Unity Version: 2022.3.6f1
  • Shaders Version: 6.3.0
  • Rendering Pipeline: Built-in

Additional context
Would be a easy fix, just minus 1 on the _AlbedoChannel in the shader source code, already did that on my version.

From SyncLinear.com | ORL-67

@JotaPe JotaPe added the bug Something isn't working label Jan 12, 2024
@JotaPe
Copy link
Author

JotaPe commented Jan 12, 2024

ORL Standard.orlshader
Line 118 From:
albedo.rgb = albedo[_AlbedoChannel].xxx;
to:
albedo.rgb = albedo[_AlbedoChannel - 1].xxx;

@JotaPe
Copy link
Author

JotaPe commented Jan 12, 2024

Figured it out when using your shader to make materials with "advanced channel packing" where the blue channel is the albedo.

@orels1 orels1 added the linear Created by Linear-GitHub Sync label Jan 12, 2024
@orels1 orels1 changed the title Albedo channel select is selecting the wrong channel [ORL-67] Albedo channel select is selecting the wrong channel Jan 12, 2024
@orels1
Copy link
Owner

orels1 commented Jan 12, 2024

Oh right, because default is RGB, so i need to offset it by 1! Good catch, and thank you for the report, I'll throw this into the next release

@orels1 orels1 added this to the ORL Shaders milestone Jan 12, 2024
@orels1 orels1 added PBR Created by Linear-GitHub Sync Shaders Created by Linear-GitHub Sync labels Jan 12, 2024
orels1 added a commit that referenced this issue May 5, 2024
- No longer off by one channel
closes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linear Created by Linear-GitHub Sync PBR Created by Linear-GitHub Sync Shaders Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants