Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionButton component not fit into the UX-design #82

Closed
hardco2020 opened this issue Mar 20, 2022 · 2 comments · Fixed by #85
Closed

ActionButton component not fit into the UX-design #82

hardco2020 opened this issue Mar 20, 2022 · 2 comments · Fixed by #85

Comments

@hardco2020
Copy link
Contributor

hardco2020 commented Mar 20, 2022

Problems

I was trying to solve the #43, when I tried to reuse the ActionButton components, I found out there are some setting on the button which will lead to some buttons not fit into the UX-design

Reproduce the problem

It supposed to be
截圖 2022-03-19 下午7 53 51

But instead
截圖 2022-03-19 下午7 52 32

How to fix

By changing the color of the ActionButton and the padding and width setting, now it looks like

截圖 2022-03-19 下午7 57 15

I can see the ActionButton supposed to be a reusable button across the whole UI, so I changed it to fit into the UX-design.

If this is indeed a part that hasn't been done, I will submit a PR regarding to the button change !

Please correct me know if there's something wrong with above messages. Thank you!

@hardco2020
Copy link
Contributor Author

@paulcretu Please review, thanks!

@DivyanshuParwal
Copy link
Contributor

@hardco2020 Go ahead and make a PR so we can review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants