Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #127: Nav bar & Footer Release 1 Desktop Updates Completed #134

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yyu233
Copy link

@yyu233 yyu233 commented Jan 15, 2024

Resolves #127

  • Nav bar:
navbar
  • Blue wavy Line when hovering over the menu options:
wavy
  • Footer
footer
  • The useIsMobile breakpoint is changed from 'sm' to 'lg' because the newly added 'Notify Me' and 'Support' buttons will cause overflow when the breakpoint is 'sm'. Here is what it looks like now:
breakpoint

* Replaced the app bar icon
* Reordered and added new nav menu items
* Changed the notification and support buttons color styles
* Hovering over the support button will invert the color of the volunteer icon
* Increased the notification and support button width
* Increased the spacing between the nav items
* Added blue wavy line png
* Hovering over navigation item will display the blue wavy line
* Added footer orca logo, third party platform icons
* Added two columns of navigation items
* Added license logo
* Updated blue wavy line implementation
* Disabled hover effect over 'Notify Me' and 'Support' buttons
* Updated useIsMobile breakpoint from 'sm' to 'lg' because the 'Notify Me'and 'Support' buttons will cause overflow when breakpoint is 'sm'
* Inverted the X and github icons color
Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for orcahome failed.

Name Link
🔨 Latest commit e96fed5
🔍 Latest deploy log https://app.netlify.com/sites/orcahome/deploys/65a64e2664401d0008dde8f4

@yyu233 yyu233 requested review from imacchiavello, DivyanshuParwal, paulcretu and UXBrendan and removed request for imacchiavello January 15, 2024 13:18
@yyu233
Copy link
Author

yyu233 commented Jan 16, 2024

@UXBrendan The build issue is due to this "./public/images/orcasound-all-rights-reserved-2023.png". I exported this image from: https://www.figma.com/file/AKxnlPthLEMQyYrYuMWqOW/Orcahome-Dev-Design?type=design&node-id=527-1615&mode=design&t=lHAg9xrPwqtz18la-0
I tried replacing this image with another export from the Figma, but it doesn't resolve the issue.
I tried npm i sharp by following vercel/next.js#37793, but it doesn't resolve the issue either.

@yyu233 yyu233 requested a review from scottveirs January 16, 2024 09:30
…u233/orcahome into yyz/feature/nav_bar_release_1_desktop
@yyu233 yyu233 changed the title Issue #127: Nav bar & Footer Release 1 Desktop Updates Completed Closes #127: Nav bar & Footer Release 1 Desktop Updates Completed Jan 16, 2024
@yyu233 yyu233 changed the title Closes #127: Nav bar & Footer Release 1 Desktop Updates Completed Resolves #127: Nav bar & Footer Release 1 Desktop Updates Completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website Redesign: Release 1 navigation bars
1 participant