Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSZ unify, it is better to use the newest geth SSZ lib #222

Open
GrapeBaBa opened this issue Nov 17, 2024 · 1 comment
Open

SSZ unify, it is better to use the newest geth SSZ lib #222

GrapeBaBa opened this issue Nov 17, 2024 · 1 comment
Assignees

Comments

@GrapeBaBa
Copy link
Member

GrapeBaBa commented Nov 17, 2024

This is the lib developed by Peter https://github.com/karalabe/ssz , we should check if go-ethereum has used it

@GrapeBaBa GrapeBaBa assigned fearlessfe and r4f4ss and unassigned fearlessfe Nov 17, 2024
@r4f4ss
Copy link

r4f4ss commented Nov 26, 2024

This is the lib developed by Peter https://github.com/karalabe/ssz , we should check if go-ethereum has used it

Geth does not use Karalabe SSZ implementation anyplace, as can be seen in go.mod file, it is not instaled in this project. I tried to search but I was not able to locate any discusion or PR to migrate to Karalabe implementation.

We should adapt Shisui to use whenever it is possible fastssz implementation, that is used by Geth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants