Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating NaNs and Infs #2

Open
gflegar opened this issue Feb 27, 2019 · 0 comments
Open

Truncating NaNs and Infs #2

gflegar opened this issue Feb 27, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gflegar
Copy link
Member

gflegar commented Feb 27, 2019

@antodo was doing some changes to the paper - trying to explain why we truncate NaNs and Inf, and figured out we do not actually need to do it.
Since we are already storing the data to the backed type, an not in lower precision, we can just store whatever was there before (it's still a NaN or Info).

Basically, we should be able to just delete the following line: https://github.com/oprecomp/FloatX/blob/master/src/floatx.hpp#L1015

@gflegar gflegar added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 27, 2019
@gflegar gflegar changed the title Truncating NaNs Truncating NaNs and Infs Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

1 participant