Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assumption in plugin.applyChanges() that a file exists #181

Open
samuelstroschein opened this issue Dec 5, 2024 — with Linear · 0 comments
Open

remove assumption in plugin.applyChanges() that a file exists #181

samuelstroschein opened this issue Dec 5, 2024 — with Linear · 0 comments

Comments

Copy link
Member

Context

applyChanges() assumes that a file exists. That is not always true.

  • a lix syncing might receive changes from one client that constructs a file
  • a file might have been deleted and should be reconstructed

Proposal

Remove the assumption that a file exists when calling plugin.applyChanges(). Plugins would need to create a new file if no file exists. Seems seems OK.

Additional information

files are computed data from changes. at no point other than opening a file with an app or getting a file out of lix is applyChanges needed. Hence, letting plugins create file (if they don't exist) seems to make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant