Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interpolated strings and variables as redirect targets #49

Open
christophermaier opened this issue Mar 31, 2017 · 1 comment
Open
Assignees
Labels

Comments

@christophermaier
Copy link
Collaborator

From @kevsmith on February 17, 2017 19:10

The following should all parse and work as expected (assuming $room is a valid variable):

echo hello > $room
echo hello > '#${room}'
echo hello > "${room}"

Copied from original issue: operable/cog#1358

@christophermaier
Copy link
Collaborator Author

From @kevsmith on February 21, 2017 15:32

After several days of research I've decided to punt this feature to post 1.0 for the following reasons:

  • Adding parser support for variable and interpolated strings as redirect targets is pretty straightforward and easy to do. Unfortunately, this is only the beginning.
  • Allowing variables and interpolated strings as redirect targets changes Cog's redirect model from one where output targets are fixed during pipeline set up to one where output targets could conceivably change on every pipeline iteration. Changes here have a lot of potential ripple effects into all aspects of pipeline processing such as output routing, template processing, and redirect target validation.

Implementing the new output routing logic, testing it, and then ensuring no regressions were introduced seems like a tall order given that we'd like to ship Cog 1.0 soon. For these reasons I've decided to delay implementing this enhancement until after 1.0 ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants