Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Edge APIs can cause ziti edge login to fail #2591

Open
andrewpmartinez opened this issue Dec 13, 2024 · 0 comments
Open

Split Edge APIs can cause ziti edge login to fail #2591

andrewpmartinez opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@andrewpmartinez
Copy link
Member

Experienced

If the edge client and management APIs are on different bind points, the ziti edge login command may fail if the default API handler does not support the **/version endpoint. This is likely to happen if the zac API bind is used.

Expected
ziti edge login continue to function.

Reproduction

  1. Deploy a controller with the following web section
web:
  - name: client-api
    bindPoints:
      - interface: 0.0.0.0:443
        address: 127.0.0.1:443
    apis:
      - binding: edge-client
        options: {}
  - name: all-the-rest
    bindPoints:
      - interface: 0.0.0.0:8443
        address: 127.0.0.1:8443
    apis:
      - binding: edge-management
        options: { }
      - binding: fabric
        options: { }
      - binding: zac
        options:
          location: /some/path/to/ziti-console/release/package
          indexFile: index.html
  1. Start the controller
  2. Attempt to ziti edge login 127.0.0.1:8443
@andrewpmartinez andrewpmartinez added the bug Something isn't working label Dec 13, 2024
@andrewpmartinez andrewpmartinez self-assigned this Dec 13, 2024
andrewpmartinez added a commit that referenced this issue Dec 13, 2024
- ziti edge login now properly probes endpoints and their return content
  type along with the existing status code check
- probed endpoint responses are no longer blindly parsed
- the management endpoint is the default initial probe point, falling
  back to the client version endpoint then the legacy root version
  endpoint
- the SPA/ZAC bindings for web apis has been moved to the webapis folder
- improved erroring and messaging for the SPA/ZAC handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant