Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ziti Controller in HA mode doesn't update binding address in a bolt database after config changed #2586

Open
nenkoru opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working distributed-control Work related to HA/Raft/other distributed control

Comments

@nenkoru
Copy link

nenkoru commented Dec 11, 2024

Continuation of #2585.

I have encountered an issue when changing the address in a config file when using HA/Raft mode doesn't update the values in bolt database. Took quite a while to debug.
Could be replicated at current HEAD at 1932a6d

Steps to replicate:

  1. Start a controller in a raft mode with binding's address with a port(eg 443)
  2. Stop the controller
  3. Change the port of the binding's address to another(eg 4433)
  4. Start the controller
  5. Query /edge/client/v1/controllers/ and see that it outputs the old port
  6. (Optional) just use a search within ctrl.db file for the old port and see that its unchanged
  7. (Optional) Use ziti ops db explore ctrl-ha.db and see that ziti.controllers.ctrl1.apiAddresses.edge-client.0 still lists old address values[1] vs new ones [2].

[1]

ziti...apiAddresses.edge-client.0> list

Key                   Type    Value
apiAddresses.url      string  https://127.0.0.1:443/edge/client/v1
apiAddresses.version  string  https://127.0.0.1:443/edge/client/v1

skipped: 0, limit: 100

[2]

web:
  - name: all-apis-localhost
    bindPoints:
      - interface: 0.0.0.0:1281
        address: 127.0.0.1:4433
    options:
      minTLSVersion: TLS1.2
      maxTLSVersion: TLS1.3
    apis:
      - binding: health-checks
      - binding: fabric
      - binding: edge-management
      - binding: edge-client
      - binding: controller-health
      - binding: edge-oidc
@nenkoru nenkoru changed the title Ziti Controller doesn't update binding address in a bolt database after config changed Ziti Controller in HA mode doesn't update binding address in a bolt database after config changed Dec 12, 2024
@plorenz plorenz self-assigned this Dec 13, 2024
@plorenz plorenz added bug Something isn't working distributed-control Work related to HA/Raft/other distributed control labels Dec 13, 2024
@plorenz plorenz moved this to Todo in Controller HA Dec 13, 2024
@plorenz
Copy link
Member

plorenz commented Dec 13, 2024

I probably broke this when I was trying to reduce unnecessary updates. I'll take a look. Thank you for reporting.

@nenkoru
Copy link
Author

nenkoru commented Dec 13, 2024

I probably broke this when I was trying to reduce unnecessary updates. I'll take a look. Thank you for reporting.

I could actually try to fix the issue if you could share the commits that potentially introduced it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed-control Work related to HA/Raft/other distributed control
Projects
Status: Todo
Development

No branches or pull requests

2 participants