Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to 5.x #767

Open
audiodude opened this issue Oct 1, 2024 · 3 comments
Open

Upgrade Bootstrap to 5.x #767

audiodude opened this issue Oct 1, 2024 · 3 comments

Comments

@audiodude
Copy link
Member

We are currently on Bootstrap 4.4.1. We received a dependabot alert of moderate severity for this version, and the upgrade path is to 5.x. However, the security alert doesn't affect us because we don't use the "carousel" component.

Either way, it's clear from this incident that security updates are no longer being backported to the 4.x branch. We should update while we have time before it becomes necessary by the next security incident.

@audiodude
Copy link
Member Author

The list of breaking changes in 5.x is quite extensive so this is not a small undertaking.

@Jaifroid
Copy link
Collaborator

It all depends on which components are used... We found in kiwix/kiwix-js#1235 that a lot of the "dropped" browsers still work (when the codebase is bundled) for our use case, and the upgrade was quite simple. (But that PR is stalled for other reasons.)

@audiodude
Copy link
Member Author

Thanks for the helpful input @Jaifroid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants