Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reencode videos and allow to choose quality preset #160

Open
benoit74 opened this issue Jan 22, 2024 · 2 comments
Open

Always reencode videos and allow to choose quality preset #160

benoit74 opened this issue Jan 22, 2024 · 2 comments
Labels
Milestone

Comments

@benoit74
Copy link
Collaborator

The scraper always re-encode with the low quality preset if the --low-quality setting is used or if the requested video format is not the same as the one used by TED.

I would have expected the scraper to reuse TED video if format is same, and re-encode with high or low preset depending on the --low-quality preset (so that we can re-encode in "high-quality").

Is this intentional?

@rgaudin
Copy link
Member

rgaudin commented Jan 22, 2024

I think the question is malformed but I'll rephrase was we intended:

  • always re-encode
  • re-encode either with strong compression is --low-quality, or with lighter settings otherwise

The main reason is to harmonize the quality of videos within a ZIM file. It's possible that the collections of videos to include are widely different in terms of quality/filesize/dimensions. re-encoding would help.

We can revisit (this choice dates back a few years) or we can extend the options to allow bundling source video.

@benoit74 benoit74 changed the title Video is almost always reencoded with low quality preset Always reencode videos and allow to choose quality preset Jan 22, 2024
@benoit74 benoit74 added bug and removed question labels Jan 22, 2024
@benoit74
Copy link
Collaborator Author

Then the scraper is not working as intended (and I like what was intended).

@benoit74 benoit74 added this to the 2.2.0 milestone Jan 22, 2024
@benoit74 benoit74 modified the milestones: 2.2.0, 3.1.0 Mar 19, 2024
@benoit74 benoit74 modified the milestones: 3.1.0, 3.2.0 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants