Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detection of libretexts.org special pages and add log #97

Open
wants to merge 1 commit into
base: assets_reliability
Choose a base branch
from

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 26, 2024

Fix #87

Changes: instead of using page title, analyzing html body to detect libretexts.org special pages

Tested on page mentioned in issue:

image

Also tested successfully on page 15834 of https://geo.libretexts.org

@benoit74 benoit74 self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.96%. Comparing base (dfe4246) to head (a86df2c).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           assets_reliability      #97      +/-   ##
======================================================
- Coverage               44.05%   43.96%   -0.09%     
======================================================
  Files                      17       17              
  Lines                    1051     1053       +2     
  Branches                  149      149              
======================================================
  Hits                      463      463              
- Misses                    576      578       +2     
  Partials                   12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review November 26, 2024 16:05
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants