zdb: show dedup table and log attributes #16755
Open
+93
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotin
reviewed
Nov 14, 2024
There's interesting info in there that is going to help with understanding dedup behaviour at any given moment. Since this is a format change, tests that rely on that output have been modified to match. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
amotin
reviewed
Nov 15, 2024
behlendorf
approved these changes
Nov 20, 2024
behlendorf
reviewed
Nov 20, 2024
| (u_longlong_t)count, | ||
| (u_longlong_t)dspace, | ||
| (u_longlong_t)mspace); | ||
| (void) printf("%s: dspace=0x%llx; mspace=0x%llx; entries=%llu\n", name, |
There was a problem hiding this comment.
Suggested change
| (void) printf("%s: dspace=0x%llx; mspace=0x%llx; entries=%llu\n", name, | |
| (void) printf("%s: dspace=%llu; mspace=%llu; entries=%llu\n", name, |
behlendorf
added
the
Status: Revision Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
Commenting on #16752, and realised we didn't have a way to definitely show what kind dedup options are in place.
Description
Extends
dump_ddt()to show container config (version, flags) and log flags and other info. A bit more lowlevel detail as befits a debugger.Goes on to show the histograms and etc as it did before, so something for everyone.
How Has This Been Tested?
Just eyeballing on various test dedup configs and load generators I have lying around.
Types of changes
Checklist:
Signed-off-by.