PR #20006: [XLA:GPU] Only allow horizontal loop fusion for default memory space #20121
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…mory space Imported from GitHub PR #20006 Horizontal loop fusion currently breaks weight offloading in JAX if it fuses a host-memory copy and device-memory copy because such a fusion results in a same-space buffer, triggering memory space assertions in JAX. This PR avoids any horizontal loop fusions for host-memory (even though in practice, some fusions would work even in host space). Copybara import of the project: -- 6a3b325 by Jaroslav Sevcik <[email protected]>: [XLA:GPU] Only allow horizontal loop fusion for default memory space Merging this change closes #20006 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20006 from jaro-sevcik:jsevcik/horizontal-loop-fusion-default-memory-space-only 6a3b325 PiperOrigin-RevId: 702636361
copybara-service
bot
force-pushed
the
test_702636361
branch
from
865f660 to
aa33481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #20006: [XLA:GPU] Only allow horizontal loop fusion for default memory space
Imported from GitHub PR #20006
Horizontal loop fusion currently breaks weight offloading in JAX if it fuses a host-memory copy and device-memory copy because such a fusion results in a same-space buffer, triggering memory space assertions in JAX.
This PR avoids any horizontal loop fusions for host-memory (even though in practice, some fusions would work even in host space).
Copybara import of the project:
--
6a3b325 by Jaroslav Sevcik [email protected]:
[XLA:GPU] Only allow horizontal loop fusion for default memory space
Merging this change closes #20006
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20006 from jaro-sevcik:jsevcik/horizontal-loop-fusion-default-memory-space-only 6a3b325