Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for LogicalAnd operation #27503

Closed
a-sidorova opened this issue Nov 11, 2024 · 2 comments · Fixed by #27709
Closed

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for LogicalAnd operation #27503

a-sidorova opened this issue Nov 11, 2024 · 2 comments · Fixed by #27709
Assignees
@nashez
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64
Milestone
2025.0

Comments

@a-sidorova
Copy link
Contributor

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that developed functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use GoogleTest filter:

./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Logical*LogicalAnd*"

Example Pull Requests

Resources

Contact points

@a-sidorova, @dmitry-gorokhov
@a-sidorova a-sidorova added good first issue Good for newcomers category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Nov 11, 2024
@nashez
Copy link
Contributor

nashez commented Nov 21, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@dmitry-gorokhov dmitry-gorokhov moved this from Contributors Needed to Assigned in Good first issues Nov 21, 2024
nashez added a commit to nashez/openvino that referenced this issue Nov 23, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation
5f16f64 
* Added a jit_logical_and_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalAnd in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalAnd entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#27503

Signed-off-by: Nashez Zubair <[email protected]>
@nashez nashez mentioned this issue Nov 23, 2024
Merged
nashez added a commit to nashez/openvino that referenced this issue Nov 23, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation
77018c0 
* Added a jit_logical_and_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalAnd in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalAnd entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#27503

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Nov 24, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation
d35392a 
* Added a jit_logical_and_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalAnd in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalAnd entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#27503

Signed-off-by: Nashez Zubair <[email protected]>
@a-sidorova a-sidorova moved this from Assigned to In Review in Good first issues Nov 25, 2024
nashez added a commit to nashez/openvino that referenced this issue Nov 26, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation
3600554 
* Added a jit_logical_and_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalAnd in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalAnd entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#27503

Signed-off-by: Nashez Zubair <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation (#27709)
c02e2ac 
### Details:

* Added a jit_logical_and_emitter derived class in
aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalAnd in the
get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalAnd entry in the aarch64 executors supported
algorithms

### Tickets:
Closes: #27503

Signed-off-by: Nashez Zubair <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Nov 26, 2024
@mlukasze mlukasze added this to the 2025.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashez nashez

Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64
Projects
Good first issues
Status: Closed
Milestone
2025.0
Development

Successfully merging a pull request may close this issue.

[CPU][ARM64] Add JIT emitter for Eltwise LogicalAnd operation nashez/openvino
3 participants
@nashez @a-sidorova @mlukasze