Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to dhw api change effective in January 2023 #285

Open
woehrl01 opened this issue Nov 30, 2022 · 8 comments
Open

Adapt to dhw api change effective in January 2023 #285

woehrl01 opened this issue Nov 30, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@woehrl01
Copy link
Collaborator

woehrl01 commented Nov 30, 2022

Important adjustment in IoT features: Split heating circuits and domestic hot water
In our API we have coupled heating circuits (HC) and domestic hot water (DHW) support closely together to keep the backwards compatibility between Legacy devices and devices based on our Viessmann One Base control platform, also called E3. Viessmann One Base provides the HCs and DHW as independent systems with a chance to access HC- and DHW-features as independent features.

What is being adjusted?

The planned adjustments brings the following changes to our IoT features:

adjust heating.circuits.N.operating.modes.* by removing existent DHW dependencies
remove heating.circuits.N.operating.modes.dhw* operating modes
adjust heating.circuits.N.operating.modes.active to only show the following states for the “value” property: auto, heating, cooling, heatingCooling or testMode
The DHW operating can in future be requested through the following new features:

introduce heating.dhw.operating.modes.off >> Shows whether the DHW is off
adjust heating.dhw.operating.modes.active >> Shows the current DHW operating mode with the possible states for the “value” property: balanced, comfort, eco, off
This change only affects our Viessmann One Base (E3) control platform (wifi integrated devices). For legacy devices, i.e. using a Vitoconnect, there are no changes. However, this also means, depending on the device, requesting and changing the DHW operating mode differs.

This will be likely a breaking change for API. We need to investigate how this can be hidden for consumers. This is also the first time we have to use different endpoints based on the sub type.

@woehrl01 woehrl01 added the enhancement New feature or request label Nov 30, 2022
@oischinger
Copy link
Contributor

Having different endpoints based on the sub type is gonna be a challenge.
I guess we will have to check dynamically which endpoint is available.
Otherwise we would need to maintain a device type/supported endpoints list :(

@woehrl01
Copy link
Collaborator Author

I just saw today, that I already made the roles available inside the service class. So this should be easier to implement then I expected.

@BrechtMo
Copy link

BrechtMo commented Jan 12, 2023

I'm having issues controlling my vitodens since this afternoon using Home Assistant. Perhaps related?

/usr/src/homeassistant/homeassistant/components/vicare/climate.py", line 370, in set_vicare_mode
    raise ValueError(f"Cannot set invalid vicare mode: {vicare_mode}.")
ValueError: Cannot set invalid vicare mode: dhwAndHeating.

This used to work without issue.

@oischinger
Copy link
Contributor

Seems like the API was finally broken by Viessmann. See above HA Core issue.

@phipz
Copy link

phipz commented Jan 15, 2023

Can confirm the same issue for Vitodens 100. However, "vicare.set_vicare_mode" to "off" and "heating" still works. Cannot see or change water on/off anymore.

Nice side effect: Changing the current target temperature finally works from home assistant (didn't work before the API change)... Weird.

@adorobis
Copy link
Contributor

adorobis commented Jan 16, 2023

Vitodens 200-W (2008 model) here and all modes still work ok. Is that something that is a rolling change or not impacting all devices?
Edit:
I've just read the change log and it won't affect the "legacy" devices:
This change only affects our Viessmann One Base (E3) control platform (wifi integrated devices). For legacy devices, i.e. using a Vitoconnect, there are no changes. However, this also means, depending on the device, requesting and changing the DHW operating mode differs.

@gras55
Copy link

gras55 commented Feb 18, 2023

Do we have any updates when this will be fixed for newer models?

@gras55
Copy link

gras55 commented Sep 10, 2023

As of today the hot water is still unable to be controlled from Home Assistant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants