feat(core-utils): add isTransitLeg function that uses transitLeg prop #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
binh-dam-ibigroup
approved these changes
Sep 23, 2024
daniel-heppner-ibigroup
merged commit 8e19f3f
into
opentripplanner:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new function (to avoid a breaking change) that checks for transit legs using the OTP2
transitLegproperty. We could add extra functionality to this in the future to check for transit legs.To avoid breaking changes in the future, is there any chance that we would want to support other arguments or return types in the future?