Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheelchair accessible labeling #682

Merged

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Nov 9, 2023

Provides invisible labeling for wheelchair accessibility badges so that users with AT can identify whether a leg or itinerary is wheelchair accessible.

See discussion on #675, closed due to mishandled merge

@@ -75,15 +95,28 @@ const AccessibilityRating = ({
// External configuration may report "0.0" as 0, so include fallback
const mapped = mapping[mappedKey] || mapping[0.0];

const accessibilityPreface = intl.formatMessage({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be up for discussion later, but instinctively, adding this text makes the whole trip summary feel too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to alternatives! There has to be some way to indicate whether the accessibility summary is referring to the leg or the trip, I think this was the best idea we had without rewriting the gradation map or making a breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I agree with you, it is a little awkwardly phrased.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I think a way to make it more clear is "Wheelchair accessibility of this trip from ____ to ____ is inaccessible/unknown".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue with that is that on any given list of trip results, they will all have the same origin and destination so it may feel a little redundant!

@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Nov 10, 2023
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good on screen reader!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 4ffabaf into opentripplanner:master Nov 20, 2023
2 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the wheelchair-a11y-labeling branch November 20, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants