-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheelchair accessible labeling #682
Wheelchair accessible labeling #682
Conversation
@@ -75,15 +95,28 @@ const AccessibilityRating = ({ | |||
// External configuration may report "0.0" as 0, so include fallback | |||
const mapped = mapping[mappedKey] || mapping[0.0]; | |||
|
|||
const accessibilityPreface = intl.formatMessage({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be up for discussion later, but instinctively, adding this text makes the whole trip summary feel too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to alternatives! There has to be some way to indicate whether the accessibility summary is referring to the leg or the trip, I think this was the best idea we had without rewriting the gradation map or making a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree with you, it is a little awkwardly phrased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I think a way to make it more clear is "Wheelchair accessibility of this trip from ____
to ____
is inaccessible/unknown
".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue with that is that on any given list of trip results, they will all have the same origin and destination so it may feel a little redundant!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good on screen reader!
Provides invisible labeling for wheelchair accessibility badges so that users with AT can identify whether a leg or itinerary is wheelchair accessible.
See discussion on #675, closed due to mishandled merge