Nearby view support (types) #681
Conversation
|
I'm thinking maybe instead of |
packages/types/src/index.ts
Outdated
| name: string; | ||
| routes?: Route[]; | ||
| gtfsId: string; |
| @@ -473,10 +486,11 @@ export type Stop = { | |||
| dist?: number; | |||
| geometries?: { geoJson?: GeoJSON.Polygon }; | |||
| id: string; | |||
There was a problem hiding this comment.
Consider adding a type alias per https://github.com/opentripplanner/otp-ui/pull/655/files#r1387985351 if we are to avoid breaking compatibility in a whole bunch of packages in #655.
There was a problem hiding this comment.
Very good suggestion, thank you
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
packages/types/src/index.ts
Outdated
| @@ -460,6 +473,8 @@ export type StopLayerStop = LayerEntity & { | |||
| name: string; | |||
| }; | |||
|
|
|||
| export type StopEventHanlder = (stop: Stop | { stopId: string }) => void; | |||
There was a problem hiding this comment.
Typo Handler
There was a problem hiding this comment.
thnx
packages/types/src/index.ts
Outdated
| lat?: number; | ||
| lon?: number; |
There was a problem hiding this comment.
Why are these marked optional?
There was a problem hiding this comment.
I added them to make something work I think, but we should probably remove them and just expect these fields to always be there.
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
merged commit fb33beb
into
opentripplanner:master
This PR adds the necessary properties to the types for the nearby view.