Nearby View: Add Location Field Search #1320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
requested changes
Dec 13, 2024
| ...nearbyViewCoords, | ||
| name: reversedPoint | ||
| }} | ||
| LocationIconComponent={() => ( |
There was a problem hiding this comment.
Hmm this isn't showing up on chrome or safari
There was a problem hiding this comment.
Also, when it does show up it feels v close to the placeholder text? Probably better suited to a OTP-UI PR, but I guess just flagging it here
There was a problem hiding this comment.
Yeah these might both be otp-ui issues!
|
These were some beautifully excellent catches thank you! All resolved |
# Conflicts: # lib/components/viewers/nearby/nearby-view.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a location field search field to the nearby view. There are still some styling concerns, and the current location issue is annoying as well. Would be nice to get that fixed.
Should we have it try to render a string on first load? If we did that then the placeholder text would never appear and that's why I'm against it.
Should we add using this thing to the Percy tests?