Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Link): Keep link active on subpaths of the tracked path #1220

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(Link): Keep link active on subpaths of the tracked path #1220

merged 1 commit into from
May 28, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR fixes the Link behavior to remain active if on a subpath of the tracked path. Unit tests added for hardening.

To test:

  1. Open the route viewer or the trips list
  2. Click a route or edit a trip.
  3. Note that previously, the route viewer link or the trip link lose their highlight. This should no longer happen with this PR.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can think of a few more unit tests to do but this is simple enough I think we're good!

@binh-dam-ibigroup
Copy link
Collaborator Author

I can think of a few more unit tests to do but this is simple enough I think we're good!

Other examples would be useful!

@miles-grant-ibigroup
Copy link
Collaborator

I can think of a few more unit tests to do but this is simple enough I think we're good!

Other examples would be useful!

First thing that comes to mind is double slash // or weird strings or other kinds of fail cases. But again it's all nitpicky stuff!

josh-willis-arcadis
josh-willis-arcadis approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binh-dam-ibigroup binh-dam-ibigroup merged commit 431e4d9 into dev May 28, 2024
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-link-tracking branch May 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @miles-grant-ibigroup @josh-willis-arcadis