Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TOS Link from Config #1080

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Add TOS Link from Config #1080

merged 10 commits into from
Dec 7, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

Allows a URL override for the Terms of Service that will direct to an external link

PR Checklist:

  • [n/a] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [n/a] Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

binh-dam-ibigroup
binh-dam-ibigroup requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the config types? Looks good otherwise.

lib/components/user/terms-of-use-pane.tsx Show resolved Hide resolved
lib/components/user/terms-of-use-pane.tsx Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks, but looks good otherwise.

lib/util/config-types.ts Outdated Show resolved Hide resolved
lib/util/config-types.ts Outdated Show resolved Hide resolved
AdrianaCeric
AdrianaCeric approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@amy-corson-ibigroup amy-corson-ibigroup merged commit f0bf5e6 into dev Dec 7, 2023
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the add-tos-from-config branch December 7, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @binh-dam-ibigroup @AdrianaCeric