Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django-REST integration? #18

Open
ror6ax opened this issue Apr 5, 2018 · 5 comments
Open

Django-REST integration? #18

ror6ax opened this issue Apr 5, 2018 · 5 comments

Comments

@ror6ax
Copy link

ror6ax commented Apr 5, 2018

Would this be able to pick up DRF interactions, like Serializer -> ORM -> DB ?

@SEJeff
Copy link

SEJeff commented Apr 19, 2018

@tomchristie do you have any thoughts on this?

@tomchristie
Copy link

@SEJeff Only that instrumenting the ORM queries really is the most important aspect.

@ror6ax
Copy link
Author

ror6ax commented Apr 23, 2018

I would also argue that having ability to customize route -> trace tags mapping would be desirable. Anyhow, I take it you guys would consider this a valid feature?

@SEJeff
Copy link

SEJeff commented Apr 23, 2018

@ror6ax I just figured out how to fix the route bit I believe. I'll send some PR's soon, but it uses this class more or less like this.

It results in the route (for a DRF app that uses rest_framework.routers.DefaultRouter for the url routing that looks like this:

alert-app-service-name: /api/alert/{pk}/

Bonus points that raven-python is also licensed under the 3 clause BSD, so we could potentially lift the code if necessary to this project.

@lovetoburnswhen
Copy link

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants