multiArchiveTag is not passed along to api when specified during archive creation.

[DropsOfSerenity]

It looks like multiArchiveTag and streamMode are not passed correctly to the api when creating an archive, due to valid_opts removing them. This does not match the documentation that says these are valid options.

We currently monkey patch OpenTok to solve this issue for us, but would like to fix the upstream issue here.

I've opened an associated PR that fixes this issue.

[superchilled]

Hi @DropsOfSerenity. Thanks for opening this issue, and for the PR. I'll review the PR and hopefully should be able to get it merged soon.

[superchilled]

Hi @DropsOfSerenity, this has been fixed in https://github.com/opentok/OpenTok-Ruby-SDK/releases/tag/v4.8.1, and is available on RubyGems.

Note: I made some additional ammendments after merging your PR which can be seen in this PR.

Specifically, I changed multi_archive_tag and stream_mode in valid_opts to snake case from camel case, since this is more idiomatic and also in keeping with the code style of the library (although the API expects the properties in camel case, the top-level keys get automatically converted here before the request is made by the Client object. I just thought I should mention this, since your PR used the camel cased versions, I assume your monkey-patch does too, so if you want to remove your monkey patch in order to use 4.8.1, you'll need to update the keys in the options hash to the snake cased versions wherever you call Archives#create. (I've also updated the docs comments accordingly, which I'm guessing is where you initially got the key names from for your PR).

Thanks again for raising the issue, and for submitting the PR.