Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkillTries gain presents progression error #2430

Closed
2 of 5 tasks
rokamdev opened this issue Mar 13, 2024 · 3 comments · Fixed by #3207
Closed
2 of 5 tasks

SkillTries gain presents progression error #2430

rokamdev opened this issue Mar 13, 2024 · 3 comments · Fixed by #3207
Labels
Priority: High Represent a high impact in key areas of the base/user experience Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@rokamdev
Copy link

Priority

High

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Any SkillTries progress (club, sword, axe, distance, fist, fishing, except Magic level) presents a progression error.
It is always being added to the skill % gain in "whole" numbers (99%, 97%, 95%, ...), never "broken" % (98.76%, 96.62%, 94.26%, ...), however after logging out and logging in, the last advance is changed to % broken.
The problem itself does not seem to be impactful, however it disregards the premium dummy, since the difference between a free dummy and a premium is 0.1x.
Although it is not a considerable difference, the skill gains in both dummies are identical, making the premium dummy unfeasible for any SkillTries training.
This problem happens with both exercise training and conventional training.
Reinforcing that Magic Level training does not fit this problem, as it is not included in SkillTries and the calculation is based on mana expenditure.
image
image2
Images show the before and after progress after logging out and logging in.
I believe the problem is related to a "uint_" added in the wrong location, but I searched the files, made some changes to test and the problem persists, beyond my ability to resolve. =/

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rokamdev rokamdev added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 13, 2024
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Mar 13, 2024
@Chapeleiiro
Copy link
Contributor

realmente tem esse erro

@myallith
Copy link
Contributor

The part where updates when re-login to a broken % is correct.

The error lies in the variation according to progress.

Copy link
Contributor

This issue is stale because it has been open 120 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Represent a high impact in key areas of the base/user experience Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants