Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KMS] Add import of KeyMaterial #2707

Open
robert1x2 opened this issue Nov 6, 2024 · 0 comments
Open

[KMS] Add import of KeyMaterial #2707

robert1x2 opened this issue Nov 6, 2024 · 0 comments
Assignees
@artem-lifshits
Labels
enhancement

Comments

@robert1x2
Copy link

Hi,

can you implement this in OTC provider please?

Add import of KeyMaterial.

https://github.com/jmcorallo/terraform-aws-kms/blob/main/main.tf#L19

OTC API does support that feature allready but is not available in OTC TF provider yet:

https://docs.otc.t-systems.com/key-management-service/api-ref/apis/cmk_management/importing_cmk_material.html#kms-02-0036

AWS has this feature implemented.
@anton-sidelnikov anton-sidelnikov self-assigned this Nov 6, 2024
@anton-sidelnikov anton-sidelnikov mentioned this issue Nov 6, 2024
Closed
@artem-lifshits artem-lifshits mentioned this issue Nov 12, 2024
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Nov 12, 2024
@artem-lifshits
KMS: keys refactoring (#2720)
5188a8a 
KMS: keys refactoring

Summary of the Pull Request
KMS keys refactoring
PR Checklist

 Refers to: #2707
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
2024/11/12 08:59:50 [INFO] Building Swift S3 auth structure
2024/11/12 08:59:50 [INFO] Setting AWS metadata API timeout to 100ms
2024/11/12 08:59:52 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2024/11/12 08:59:52 [INFO] Swift S3 Auth provider used: "StaticProvider"
=== RUN   TestAccKmsKeyV1_basic
--- PASS: TestAccKmsKeyV1_basic (192.59s)
=== RUN   TestAccKmsKey_isEnabled
--- PASS: TestAccKmsKey_isEnabled (270.68s)
=== RUN   TestAccKmsKey_rotation
--- PASS: TestAccKmsKey_rotation (113.89s)
=== RUN   TestAccKmsKey_cancelDeletion
--- PASS: TestAccKmsKey_cancelDeletion (114.79s)
=== RUN   TestAccKmsKey_cancelDeletionWithRotation
--- PASS: TestAccKmsKey_cancelDeletionWithRotation (114.05s)
PASS

Process finished with the exit code 0

2024/11/12 10:08:04 [INFO] Building Swift S3 auth structure
2024/11/12 10:08:04 [INFO] Setting AWS metadata API timeout to 100ms
2024/11/12 10:08:05 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2024/11/12 10:08:05 [INFO] Swift S3 Auth provider used: "StaticProvider"
=== RUN   TestAccKmsDataKeyV1DataSource_basic
--- PASS: TestAccKmsDataKeyV1DataSource_basic (187.50s)
PASS

Process finished with the exit code 0

=== RUN   TestAccKmsKeyV1DataSource_basic
--- PASS: TestAccKmsKeyV1DataSource_basic (49.49s)
PASS

Process finished with the exit code 0

Reviewed-by: Anton Sidelnikov
@artem-lifshits artem-lifshits mentioned this issue Nov 15, 2024
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Nov 15, 2024
@artem-lifshits
KMS: import of keymaterial (#2731)
f3fc266 
KMS: import of keymaterial

Summary of the Pull Request

Enhancement to change KMS origin
New resource: resource/opentelekomcloud_kms_key_material_v1
New data source: data_source/opentelekomcloud_kms_key_material_parameters_v1

PR Checklist

 Refers to: #2707
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
2024/11/15 13:58:48 [INFO] Building Swift S3 auth structure
2024/11/15 13:58:48 [INFO] Setting AWS metadata API timeout to 100ms
2024/11/15 13:58:49 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2024/11/15 13:58:49 [INFO] Swift S3 Auth provider used: "StaticProvider"
=== RUN   TestAccKmsImportParamsV1DataSource_basic
--- PASS: TestAccKmsImportParamsV1DataSource_basic (99.13s)
PASS

Process finished with the exit code 0

2024/11/15 14:08:28 [INFO] Building Swift S3 auth structure
2024/11/15 14:08:28 [INFO] Setting AWS metadata API timeout to 100ms
2024/11/15 14:08:30 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2024/11/15 14:08:30 [INFO] Swift S3 Auth provider used: "StaticProvider"
=== RUN   TestAccKmsKeyMaterial_Symmetric
--- PASS: TestAccKmsKeyMaterial_Symmetric (131.59s)
PASS

Process finished with the exit code 0

2024/11/15 15:58:39 [INFO] Building Swift S3 auth structure
2024/11/15 15:58:39 [INFO] Setting AWS metadata API timeout to 100ms
2024/11/15 15:58:40 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2024/11/15 15:58:40 [INFO] Swift S3 Auth provider used: "StaticProvider"
=== RUN   TestAccKmsKeyV1_basic
--- PASS: TestAccKmsKeyV1_basic (195.41s)
=== RUN   TestAccKmsKey_isEnabled
--- PASS: TestAccKmsKey_isEnabled (272.98s)
=== RUN   TestAccKmsKey_rotation
--- PASS: TestAccKmsKey_rotation (113.45s)
=== RUN   TestAccKmsKey_cancelDeletion
--- PASS: TestAccKmsKey_cancelDeletion (113.20s)
=== RUN   TestAccKmsKey_cancelDeletionWithRotation
--- PASS: TestAccKmsKey_cancelDeletionWithRotation (113.36s)
=== RUN   TestAccKmsKey_externalKey
--- PASS: TestAccKmsKey_externalKey (112.90s)
PASS

Process finished with the exit code 0

Reviewed-by: Aloento
Reviewed-by: Anton Sidelnikov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-lifshits artem-lifshits

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robert1x2 @anton-sidelnikov @artem-lifshits