Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move code from golangsdk package #419

Open
2 tasks
outcatcher opened this issue Sep 5, 2022 · 0 comments
Open
2 tasks

Refactor: move code from golangsdk package #419

outcatcher opened this issue Sep 5, 2022 · 0 comments
Assignees
@outcatcher
Labels
enhancement New feature or request

Comments

@outcatcher
Copy link
Contributor

outcatcher commented Sep 5, 2022 •
edited
Loading

Currently, base golangsdk package is filled with a lot of core functionality, methods and structures. All of them should be moved to other packages depending on their responsibility scope.

NOTE: this should be done using graceful deprecation approach, not removing exported items less than two minor releases from deprecation.

Moved to packages:

  • params.go
  • ...
@outcatcher outcatcher added the enhancement New feature or request label Sep 5, 2022
@outcatcher outcatcher changed the title Refactor: move code from root package Refactor: move code from golangsdk package Sep 5, 2022
@outcatcher outcatcher self-assigned this Sep 8, 2022
@outcatcher outcatcher mentioned this issue Sep 14, 2022
Merged
otc-zuul bot pushed a commit that referenced this issue Sep 23, 2022
@outcatcher
Move building opts to internal/build package / Add pointer converter (
6db5b6d 
#424)

Move building opts to `internal/build` package / Add pointer converter

What this PR does / why we need it
Deprecate methods for building request bodies, query strings, headers in golangsdk package
Move them to internal/build package
Add helper package common/pointerto
Add helper internal/multierr package for handling multiple errors
Which issue this PR fixes

Part of #419
Resolve #294
Special notes for your reviewer
Current SDK methods are not affected.

Reviewed-by: Aloento <None>
Reviewed-by: Anton Sidelnikov <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outcatcher outcatcher

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@outcatcher